Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan to stop v2, target is 2021-11-30 #1078

Closed
3 tasks
shirou opened this issue May 29, 2021 · 3 comments
Closed
3 tasks

Plan to stop v2, target is 2021-11-30 #1078

shirou opened this issue May 29, 2021 · 3 comments

Comments

@shirou
Copy link
Owner

shirou commented May 29, 2021

Is your feature request related to a problem? Please describe.

This is a feature request.

Describe the solution you'd like

Currently gopsutil have two versions, v2 and v3. But it is difficult to support both versions from our limited resource. I want to terminate v2 and move v3 version to root directory.

My plan is 6 months later, end of November of this year, this means 2021-11-30. After that day, we will not have v2 any more. Please migrate your code from v2 to v3 until that day.

Plan

  • Oct.: check difference between v2 and v3. If there is something which v3 doesn't have, open a PR.
  • Beginning of Nov.: Open a PR which move v3 to root, and check feasibility.
  • End of Nov.: merge the PR.
@Lomanic
Copy link
Collaborator

Lomanic commented Aug 18, 2021

Do you plan on removing v2 files or just freeze the sub-packages? I fear that that removing files would break a lot of things downstream.

Otherwise, I agree with the idea of freezing v2.

@shirou
Copy link
Owner Author

shirou commented Aug 19, 2021

I am planning remove v2 files and move v3 to top. I understand it breaks a lot, but it's something we are going to have to do at some point.

@Lomanic
Copy link
Collaborator

Lomanic commented Feb 23, 2022

Closing with #1174 merged

@Lomanic Lomanic closed this as completed Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants