Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change KMeans "mus" parameter #4962

Merged
merged 7 commits into from
Mar 29, 2020
Merged

Change KMeans "mus" parameter #4962

merged 7 commits into from
Mar 29, 2020

Conversation

LiuYuHui
Copy link
Contributor

@LiuYuHui LiuYuHui commented Mar 26, 2020 •
edited
Loading

fix #4847

@LiuYuHui LiuYuHui changed the title Kmeans Change KMeans "mus" parameter Mar 26, 2020
gf712
gf712 reviewed Mar 26, 2020
View reviewed changes
Copy link
Member

@gf712 gf712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to find a way to initialise KMeans with clusters centres provided by the user using something like .put("initial_clusters"). Then when KMeans runs it will either initialise cluster centres itself or use the user provided values.

src/shogun/clustering/KMeansBase.cpp Show resolved Hide resolved
@gf712
Copy link
Member

gf712 commented Mar 27, 2020

Could you trigger the CI now that it is working again?

@gf712
Copy link
Member

gf712 commented Mar 28, 2020

I think this is ready to be merged. @vigsterkr what do you think?

@vigsterkr
Copy link
Member

👍 lets wait till CIs are green and then lets merge it! \o/

gf712
gf712 requested changes Mar 28, 2020
View reviewed changes
Copy link
Member

@gf712 gf712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just saw this was causing issues in notebook

doc/ipython-notebooks/clustering/KMeans.ipynb Outdated Show resolved Hide resolved
@vinnik-dmitry07 vinnik-dmitry07 mentioned this pull request Mar 28, 2020
Closed
@gf712 gf712 merged commit d18c18a into shogun-toolbox:develop Mar 29, 2020
@gf712
Copy link
Member

gf712 commented Mar 29, 2020

Good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlnapf karlnapf karlnapf left review comments

@gf712 gf712 gf712 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change KMeans "mus" parameter to something more user friendly
4 participants
@LiuYuHui @gf712 @vigsterkr @karlnapf