Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy argument is unsupported in sync client since v2.6 #714

Closed
4 of 9 tasks
seratch opened this issue Jun 4, 2020 · 0 comments
Closed
4 of 9 tasks

proxy argument is unsupported in sync client since v2.6 #714

seratch opened this issue Jun 4, 2020 · 0 comments
Assignees
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 2x web-client
Milestone

Comments

@seratch
Copy link
Member

seratch commented Jun 4, 2020

Description

Since v2.6.0, run_async=False mode WebClient hasn't been working with proxy option.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

Reproducible in:

  • slackclient version: v2.6.0+
  • python version: any
  • OS version(s): any

Steps to reproduce:

import os
from slack import WebClient

client = WebClient(
    token=os.environ["SLACK_API_TOKEN"],
    proxy="http://localhost:9000"
)
response = client.auth_test()
logger.info(f"sync response: {response}")

Expected result:

urllib.error.URLError: <urlopen error [Errno 61] Connection refused>

Actual result:

WebClient ignores the proxy setting. It successfully sends a request to Slack.

@seratch seratch added Version: 2x bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented web-client labels Jun 4, 2020
@seratch seratch added this to the 2.7.1 milestone Jun 4, 2020
@seratch seratch self-assigned this Jun 4, 2020
@seratch seratch closed this as completed in d02beb5 Jun 4, 2020
seratch added a commit that referenced this issue Jun 4, 2020
Fix #714 by adding proxy support for sync WebClient
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 2x web-client
Projects
None yet
Development

No branches or pull requests

1 participant