Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to rtm.connect docs #223

Merged
merged 1 commit into from
Sep 19, 2017
Merged

Fix link to rtm.connect docs #223

merged 1 commit into from
Sep 19, 2017

Conversation

sampart
Copy link

@sampart sampart commented Sep 12, 2017

Summary

Fix link to rtm.connect docs in docs-src/real_time_messaging.rst

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Sep 12, 2017

Codecov Report

Merging #223 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #223   +/-   ##
=======================================
  Coverage   59.67%   59.67%           
=======================================
  Files           9        9           
  Lines         310      310           
  Branches       57       57           
=======================================
  Hits          185      185           
  Misses        111      111           
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a9c546...18ca527. Read the comment docs.

@Roach
Copy link
Contributor

Roach commented Sep 14, 2017

@sampart can you merge master and run tox -e docs on this branch? I'll get it merged in as soon as the docs are regenerated 👍

@Roach Roach self-assigned this Sep 14, 2017
@sampart
Copy link
Author

sampart commented Sep 18, 2017

@Roach do you definitely want a merge, or could I rebase off master? I'd rather not have an unnecessary merge commit. Thanks

@Roach
Copy link
Contributor

Roach commented Sep 18, 2017

@sampart I'm fine with either, whichever works for you 👍

@sampart
Copy link
Author

sampart commented Sep 19, 2017

@Roach I've rebased the branch and amended the commit to include the generated docs too. Let me know if you need anything more from me. Thanks

@Roach Roach merged commit a8d3f37 into slackapi:master Sep 19, 2017
@Roach Roach mentioned this pull request Nov 22, 2017
2 tasks
c-goosen pushed a commit to c-goosen/python-slackclient that referenced this pull request Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants