Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #714 by adding proxy support for sync WebClient #715

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

seratch
Copy link
Member

@seratch seratch commented Jun 4, 2020

Summary

This pull request fixes a regression in v2.6.0 #714

Requirements (place an x in each [ ])

@seratch seratch added Version: 2x bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented web-client labels Jun 4, 2020
@seratch seratch added this to the 2.7.1 milestone Jun 4, 2020
@seratch seratch requested a review from stevengill June 4, 2020 09:57
@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #715 into master will decrease coverage by 0.17%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #715      +/-   ##
==========================================
- Coverage   85.08%   84.91%   -0.18%     
==========================================
  Files          22       22              
  Lines        2783     2790       +7     
  Branches      277      279       +2     
==========================================
+ Hits         2368     2369       +1     
- Misses        312      317       +5     
- Partials      103      104       +1     
Impacted Files Coverage Δ
slack/web/base_client.py 70.73% <14.28%> (-1.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b937e4...d02beb5. Read the comment docs.

@seratch seratch mentioned this pull request Jun 4, 2020
2 tasks
seratch added a commit to seratch/python-slack-sdk that referenced this pull request Jun 4, 2020
@seratch seratch merged commit af377a5 into slackapi:master Jun 4, 2020
@seratch seratch deleted the issue-714 branch June 4, 2020 20:55
seratch added a commit to seratch/python-slack-sdk that referenced this pull request Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 2x web-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants