Fix #733 Better error handling when getting TimeoutError in RTMClient#start() #752
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TMClient#start()
Codecov Report
@@ Coverage Diff @@
## main #752 +/- ##
==========================================
- Coverage 85.19% 85.13% -0.07%
==========================================
Files 22 22
Lines 2810 2812 +2
Branches 283 284 +1
==========================================
Hits 2394 2394
- Misses 311 312 +1
- Partials 105 106 +1
Continue to review full report at Codecov.
|
stevengill
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes #733. As the situation is not so easy to reproduce, I didn't write unit tests for this change. I'm sure the change is safe enough, though.
Requirements (place an
xin each[ ])