Fix #770 by adding bytes type param support #771
Merged
+45
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #771 +/- ##
=======================================
Coverage 87.25% 87.25%
=======================================
Files 30 30
Lines 3585 3585
Branches 316 316
=======================================
Hits 3128 3128
Misses 325 325
Partials 132 132
Continue to review full report at Codecov.
|
seratch
commented
Aug 6, 2020
|
|
||
| export SLACK_SDK_TEST_BOT_TOKEN=xoxb-xxx | ||
| export SLACK_SDK_TEST_WEB_TEST_CHANNEL_ID=C111 | ||
| python setup.py run_integration_tests --test-target integration_tests/web/test_issue_770.py |
There was a problem hiding this comment.
You can run this test by these steps.
seratch
added a commit
that referenced
this pull request
Aug 6, 2020
stevengill
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes #770. Refer to the issue for details.
Requirements (place an
xin each[ ])