Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct Block.parse(dict) to support CallBlock #775

Merged
merged 2 commits into from
Aug 6, 2020
Merged

Correct Block.parse(dict) to support CallBlock #775

merged 2 commits into from
Aug 6, 2020
+10 −0

Conversation

seratch
Copy link
Member

@seratch seratch commented Aug 6, 2020

Summary

While reviewing #768 , I found that CallBlock is not yet supported in Block.parse(dict) method. The block class was introduced by #704. I missed changing the class method in the PR.

Requirements (place an x in each [ ])

@seratch seratch added Version: 2x bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented labels Aug 6, 2020
@seratch seratch added this to the 2.8.0 milestone Aug 6, 2020
@seratch seratch self-assigned this Aug 6, 2020
@codecov
Copy link

codecov bot commented Aug 6, 2020 •
edited
Loading

Codecov Report

Merging #775 into main will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #775      +/-   ##
==========================================
+ Coverage   87.30%   87.36%   +0.06%     
==========================================
  Files          30       30              
  Lines        3600     3602       +2     
  Branches      317      318       +1     
==========================================
+ Hits         3143     3147       +4     
+ Misses        324      323       -1     
+ Partials      133      132       -1
Impacted Files Coverage Δ
slack/web/classes/blocks.py 93.65% <100.00%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebb508d...ef8f20e. Read the comment docs.

mwbrooks added a commit that referenced this pull request Aug 6, 2020
@mwbrooks
[#767] Improve Codecov by adding HeaderBlock test for Block.parse.
0ed0b11 
- See #775 where Block.parse coverage is added for other blocks
@mwbrooks mwbrooks mentioned this pull request Aug 6, 2020
Merged
2 tasks
seratch pushed a commit that referenced this pull request Aug 6, 2020
@mwbrooks
[Fix #767] Add header block support (#768)
936f21a 
* [#767] Add header block support.
* [#767] Update HeaderBlock validation to not include fields.
* [#767] Improve Codecov by adding HeaderBlock test for Block.parse.
- See #775 where Block.parse coverage is added for other blocks
@seratch seratch merged commit 0a3eeb8 into slackapi:main Aug 6, 2020
@seratch seratch deleted the block-parse-call branch August 6, 2020 22:07
seratch pushed a commit that referenced this pull request Aug 6, 2020
@mwbrooks @seratch
[Fix #767] Add header block support (#768)
7c82569 
* [#767] Add header block support.
* [#767] Update HeaderBlock validation to not include fields.
* [#767] Improve Codecov by adding HeaderBlock test for Block.parse.
- See #775 where Block.parse coverage is added for other blocks
seratch added a commit that referenced this pull request Aug 6, 2020
@seratch
Fix Block.parse to support CallBlock (#775)
bdccd79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwbrooks mwbrooks

@stevengill stevengill

@misscoded misscoded

Assignees

@seratch seratch

Labels
bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented Version: 2x
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seratch @mwbrooks @stevengill