This repository has been archived by the owner on Mar 10, 2024. It is now read-only.
feat: add option to ignore untracked files #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows new files that are not yet tracked in git to be excluded from reporting.
kpdecker
commented
May 7, 2021
| }, | ||
| ) | ||
| .help().argv; | ||
| if (process.env.NODE_ENV !== 'test') { |
There was a problem hiding this comment.
There was a race condition in the tests with this running in the background. The addition of the additional async calls for the git logic, even though mocked, exposed this, leading to inconsistent behavior within the jest tests.
|
Nice one! Thanks! Also, I've added you as a collaborator on the project. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Welcome to the team 🎉 |
|
published as |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows new files that are not yet tracked in git to be excluded from reporting.