Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve panic message for when a task is polled after completion #73

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Improve panic message for when a task is polled after completion #73

merged 1 commit into from
Apr 23, 2024

Conversation

SkiFire13
Copy link
Contributor

This created some confusion in bevyengine/bevy#13072

taiki-e
taiki-e approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@taiki-e taiki-e merged commit 3cfa07f into smol-rs:master Apr 23, 2024
8 checks passed
@SkiFire13 SkiFire13 deleted the better-panic-msg branch April 23, 2024 15:34
@notgull notgull mentioned this pull request Apr 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SkiFire13 @taiki-e