Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: snc/SncRedisBundle
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4.6.1
Choose a base ref
...
head repository: snc/SncRedisBundle
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4.7.0
Choose a head ref
  • 3 commits
  • 6 files changed
  • 2 contributors

Commits on Sep 14, 2023

  1. CI: fix deprecations

    ostrolucky committed Sep 14, 2023

    Verified

    This commit was signed with the committer’s verified signature.
    ostrolucky Gabriel Ostrolucký
    Copy the full SHA
    e25a15c View commit details

Commits on Oct 3, 2023

  1. 2

    Verified

    This commit was signed with the committer’s verified signature.
    ostrolucky Gabriel Ostrolucký
    Copy the full SHA
    77e827a View commit details

Commits on Nov 1, 2023

  1. Allow Symfony 7.0

    vtsykun authored and ostrolucky committed Nov 1, 2023

    Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Copy the full SHA
    ff9c4e6 View commit details
Showing with 32 additions and 29 deletions.
  1. +4 −4 .github/workflows/continuous-integration.yml
  2. +13 −14 composer.json
  3. +6 −6 flake.lock
  4. +2 −2 flake.nix
  5. +1 −2 src/DependencyInjection/SncRedisExtension.php
  6. +6 −1 tests/Functional/App/Kernel.php
8 changes: 4 additions & 4 deletions .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
@@ -25,12 +25,12 @@ jobs:
- symfony-require: "5.4.*"
php-version: "8.2"
php-extensions: "redis"
- symfony-require: "6.2.*"
php-version: "8.2"
php-extensions: "redis"
- symfony-require: "6.3.*"
- symfony-require: "6.4.*"
php-version: "8.2"
php-extensions: "redis-phpredis/phpredis@develop"
- symfony-require: "7.0.*"
php-version: "8.2"
php-extensions: "redis"

steps:
- name: "Checkout"
27 changes: 13 additions & 14 deletions composer.json
Original file line number Diff line number Diff line change
@@ -23,10 +23,10 @@
"require": {
"php": "^7.4 || ^8.0",
"symfony/deprecation-contracts": "^2 || ^3",
"symfony/framework-bundle": "^4.4 || ^5.3 || ^6.0",
"symfony/http-foundation": "^4.4 || ^5.3 || ^6.0",
"symfony/framework-bundle": "^4.4 || ^5.3 || ^6.0 || ^7.0",
"symfony/http-foundation": "^4.4 || ^5.3 || ^6.0 || ^7.0",
"symfony/service-contracts": ">=1.0",
"symfony/var-dumper": "^4.4 || ^5.3 || ^6.0"
"symfony/var-dumper": "^4.4 || ^5.3 || ^6.0 || ^7.0"
},
"require-dev": {
"ext-pdo_sqlite": "*",
@@ -37,23 +37,22 @@
"monolog/monolog": "*",
"phpunit/phpunit": "^8.5.32 || ^9.5.28",
"predis/predis": "^2.0",
"symfony/browser-kit": "^4.4 || ^5.3 || ^6.0",
"symfony/cache": "^4.4 || ^5.3 || ^6.0",
"symfony/console": "^4.4 || ^5.3 || ^6.0",
"symfony/dom-crawler": "^4.4 || ^5.3 || ^6.0",
"symfony/filesystem": "^4.4 || ^5.3 || ^6.0",
"symfony/phpunit-bridge": "^6.0",
"symfony/browser-kit": "^4.4 || ^5.3 || ^6.0 || ^7.0",
"symfony/cache": "^4.4 || ^5.3 || ^6.0 || ^7.0",
"symfony/console": "^4.4 || ^5.3 || ^6.0 || ^7.0",
"symfony/dom-crawler": "^4.4 || ^5.3 || ^6.0 || ^7.0",
"symfony/filesystem": "^4.4 || ^5.3 || ^6.0 || ^7.0",
"symfony/phpunit-bridge": "^6.0 || ^7.0",
"symfony/profiler-pack": "^1.0",
"symfony/stopwatch": "^4.4 || ^5.3 || ^6.0",
"symfony/twig-bundle": "^4.4 || ^5.3 || ^6.0",
"symfony/yaml": "^4.4 || ^5.3 || ^6.0",
"symfony/stopwatch": "^4.4 || ^5.3 || ^6.0 || ^7.0",
"symfony/twig-bundle": "^4.4 || ^5.3 || ^6.0 || ^7.0",
"symfony/yaml": "^4.4 || ^5.3 || ^6.0 || ^7.0",
"vimeo/psalm": "^5.2"
},
"suggest": {
"monolog/monolog": "If you want to use the monolog redis handler.",
"predis/predis": "If you want to use predis.",
"symfony/console": "If you want to use commands to interact with the redis database",
"symfony/proxy-manager-bridge": "If you want to lazy-load some services"
"symfony/console": "If you want to use commands to interact with the redis database"
},
"config": {
"sort-packages": true,
12 changes: 6 additions & 6 deletions flake.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions flake.nix
Original file line number Diff line number Diff line change
@@ -30,8 +30,8 @@
src = pkgs.fetchFromGitHub {
repo = "phpredis";
owner = "phpredis";
rev = "fea19b5229343212424c9921a977fce300d4e130";
sha256 = "sha256-1TII8sLDsH9Ufjl0HHtHtBi29FNEG2qNrMkMhM6+iO0=";
rev = "2bddd84f2f653ee3e956a4683f9938787905f72d";
sha256 = "sha256-quKibCW9bMselVNWdu4ZfdZ+dcDYmQxBnKVCHwYpRJA=";
};
}))
# relay section https://relay.so/docs/1.x/installation#manual-installation
3 changes: 1 addition & 2 deletions src/DependencyInjection/SncRedisExtension.php
Original file line number Diff line number Diff line change
@@ -21,7 +21,6 @@
use Snc\RedisBundle\DependencyInjection\Configuration\RedisEnvDsn;
use Snc\RedisBundle\Factory\PredisParametersFactory;
use Snc\RedisBundle\Logger\RedisCallInterceptor;
use Symfony\Bridge\ProxyManager\LazyProxy\PhpDumper\ProxyDumper;
use Symfony\Component\Config\Definition\ConfigurationInterface;
use Symfony\Component\Config\Definition\Exception\InvalidConfigurationException;
use Symfony\Component\Config\FileLocator;
@@ -233,7 +232,7 @@ private function loadPhpredisClient(array $options, ContainerBuilder $container)
]);
$phpredisDef->setFactory([new Reference('snc_redis.phpredis_factory'), 'create']);
$phpredisDef->addTag('snc_redis.client', ['alias' => $options['alias']]);
$phpredisDef->setLazy(class_exists(ProxyDumper::class));
$phpredisDef->setLazy(true);

$container->setDefinition(sprintf('snc_redis.%s', $options['alias']), $phpredisDef);
}
7 changes: 6 additions & 1 deletion tests/Functional/App/Kernel.php
Original file line number Diff line number Diff line change
@@ -13,6 +13,7 @@

namespace Snc\RedisBundle\Tests\Functional\App;

use Doctrine\Common\Annotations\Annotation;
use ReflectionObject;
use Snc\RedisBundle\SncRedisBundle;
use Snc\RedisBundle\Tests\Functional\App\Controller\Controller;
@@ -28,6 +29,7 @@
use Symfony\Component\Routing\RouteCollection;

use function assert;
use function class_exists;
use function dirname;

class Kernel extends BaseKernel
@@ -50,7 +52,10 @@ public function registerContainerConfiguration(LoaderInterface $loader): void
$loader->load(__DIR__ . '/config.yaml');

$loader->load(static function (ContainerBuilder $container): void {
$framework = ['router' => ['resource' => 'kernel::loadRoutes', 'type' => 'service', 'utf8' => true]];
$framework = [
'router' => ['resource' => 'kernel::loadRoutes', 'type' => 'service', 'utf8' => true],
'annotations' => class_exists(Annotation::class) && self::VERSION_ID < 60400,
];

// Since symfony/framework-bundle 5.3: Not setting the "framework.session.storage_factory_id" configuration option
// is deprecated, it will replace the "framework.session.storage_id" configuration option in version 6.0.