Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installing symfony versions in CI #716

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu commented Nov 1, 2023

I've seen the new release and I was checking the versions installed and for example for:

It's installing the packages in the flex step and using incorrect versions.

I've removed psalm/vimeo in the job when the using Symfony 4.4 because it requires "symfony/filesystem": "^5.4 || ^6.0",.

I've added the "prefer-stable" section since it was installing dev versions for stable ones (4.4 and 5.4).

@ostrolucky
Copy link
Collaborator

This bundle doesn't use symfony/filesystem, so I would say its version doesn't matter. Fixing installation of other packages when installing flex is good that you fixed, though.

@franmomu
Copy link
Contributor Author

franmomu commented Nov 1, 2023

This bundle doesn't use symfony/filesystem, so I would say its version doesn't matter. Fixing installation of other packages when installing flex is good that you fixed, though.

Apparently it does:

"symfony/filesystem": "^4.4 || ^5.3 || ^6.0 || ^7.0",

because of:

use Symfony\Component\Filesystem\Filesystem;

@ostrolucky ostrolucky merged commit 0ffe9e7 into snc:master Nov 2, 2023
7 checks passed
@franmomu franmomu deleted the fix_ci branch November 2, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants