Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless options #1314

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

VincentLanglet
Copy link
Member

@VincentLanglet VincentLanglet commented Feb 17, 2021

Subject

We're setting code, name and label.

  • As explained here, I think that removing code should be considered as a bugfix.
  • The name option is not used.
  • The label option is useless ; it's already set in the SonataAdminBundle, so the line is doing nothing.

I try it on my project and saw no impact.

Changelog

### Fixed
- Unavoidable deprecation about the `code` option.

@VincentLanglet VincentLanglet requested a review from a team February 17, 2021 23:54
@VincentLanglet VincentLanglet marked this pull request as ready for review February 17, 2021 23:54
Copy link
Contributor

@dmaicher dmaicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure of the impact. But since you tested it should be fine 👍

@dmaicher dmaicher requested a review from a team February 18, 2021 08:14
@OskarStark OskarStark merged commit aa3e327 into sonata-project:3.x Feb 18, 2021
@OskarStark
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants