-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update constraints in order to allow some "symfony/*:^5.2" deps #1335
Conversation
composer.json
Outdated
"symfony/doctrine-bridge": "^4.4", | ||
"symfony/form": "^4.4", | ||
"symfony/framework-bundle": "^4.4", | ||
"symfony/http-foundation": "^4.4", | ||
"symfony/http-foundation": "^4.4 || ^5.2", | ||
"symfony/http-kernel": "^4.4", | ||
"symfony/options-resolver": "^4.4 || ^5.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should you update the 5.1 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If 5.1 works, why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So why using ^5.2
for others ?
We could even use ^5.0
every time.
I thought our policy was to allow only supported version. https://symfony.com/releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure but this Pr is for supporting new versions, why should we raise the bar for a version which we already support?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you agree, I can use 5.1 or 5.2 based on the decision we take.
Please, let me know what your suggestions are in order to get this PR merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to be to picky, I am fine with a bump to 5.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont really have preference about the one chosen but Id like to have consistency :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Thanks ! |
Ok @phansys, I requested a new release for SonataDoctrineORMAdminBundle via Slack in If you want to get notified about new releases, make sure to follow SonataNews on Twitter! |
Subject
Update constraints in order to allow some "symfony/*:^5.2" deps.
I am targeting this branch, because these changes respect BC.
Changelog