Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update constraints in order to allow some "symfony/*:^5.2" deps #1335

Merged
merged 1 commit into from
Mar 6, 2021

Conversation

phansys
Copy link
Member

@phansys phansys commented Mar 5, 2021

Subject

Update constraints in order to allow some "symfony/*:^5.2" deps.

I am targeting this branch, because these changes respect BC.

Changelog

### Added
- Support for symfony/config:^5.2;
- Support for symfony/dependency-injection:^5.2;
- Support for symfony/http-foundation:^5.2.

@phansys phansys marked this pull request as ready for review March 5, 2021 21:09
@phansys phansys requested a review from a team March 5, 2021 22:47
composer.json Outdated
"symfony/doctrine-bridge": "^4.4",
"symfony/form": "^4.4",
"symfony/framework-bundle": "^4.4",
"symfony/http-foundation": "^4.4",
"symfony/http-foundation": "^4.4 || ^5.2",
"symfony/http-kernel": "^4.4",
"symfony/options-resolver": "^4.4 || ^5.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you update the 5.1 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If 5.1 works, why?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So why using ^5.2 for others ?

We could even use ^5.0 every time.
I thought our policy was to allow only supported version. https://symfony.com/releases

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure but this Pr is for supporting new versions, why should we raise the bar for a version which we already support?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you agree, I can use 5.1 or 5.2 based on the decision we take.
Please, let me know what your suggestions are in order to get this PR merged.

Copy link
Member

@OskarStark OskarStark Mar 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to be to picky, I am fine with a bump to 5.2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont really have preference about the one chosen but Id like to have consistency :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@VincentLanglet VincentLanglet merged commit 3f27b61 into sonata-project:3.x Mar 6, 2021
@VincentLanglet
Copy link
Member

Thanks !

@phansys phansys deleted the deps branch March 6, 2021 22:20
@SonataCI
Copy link
Collaborator

SonataCI commented Mar 9, 2021

Ok @phansys,

I requested a new release for SonataDoctrineORMAdminBundle via Slack in #releases channel 👍

If you want to get notified about new releases, make sure to follow SonataNews on Twitter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants