Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplicate query with current page results #1480

Merged
merged 2 commits into from
Jul 17, 2021
Merged

Avoid duplicate query with current page results #1480

merged 2 commits into from
Jul 17, 2021
+29 −1

Conversation

VincentLanglet
Copy link
Member

@VincentLanglet VincentLanglet commented Jul 16, 2021 •
edited
Loading

Subject

See sonata-project/SonataAdminBundle#7328

Changelog

### Changed
`Pager::getCurrentPageResults()` does not return `Paginator` anymore.

@VincentLanglet
Avoid duplicate query with current page results

Verified

This commit was signed with the committer’s verified signature.
TylerHelmuth Tyler Helmuth
GPG key ID: 291C22FD8611B5B8
Verified
Learn about vigilant mode
74d5e09
@VincentLanglet VincentLanglet marked this pull request as draft July 16, 2021 11:25
@VincentLanglet VincentLanglet mentioned this pull request Jul 16, 2021
Closed
@VincentLanglet VincentLanglet marked this pull request as ready for review July 16, 2021 12:46
@VincentLanglet VincentLanglet requested a review from a team July 16, 2021 12:47
jordisala1991
jordisala1991 previously approved these changes Jul 16, 2021
View reviewed changes
@VincentLanglet VincentLanglet requested a review from a team July 16, 2021 13:46
@VincentLanglet VincentLanglet added this to the 4.0 milestone Jul 16, 2021
phansys
phansys previously approved these changes Jul 17, 2021
View reviewed changes
Copy link
Member

@phansys phansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test for this change?

@VincentLanglet VincentLanglet dismissed stale reviews from phansys and jordisala1991 via 30bfcbe July 17, 2021 16:36
@VincentLanglet
Add tests

Verified

This commit was signed with the committer’s verified signature.
TylerHelmuth Tyler Helmuth
GPG key ID: 291C22FD8611B5B8
Verified
Learn about vigilant mode
62c91c5
@VincentLanglet VincentLanglet merged commit 189f160 into sonata-project:master Jul 17, 2021
@VincentLanglet VincentLanglet deleted the reduceQuery branch July 17, 2021 16:45
@VincentLanglet
Copy link
Member Author

I added a test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordisala1991 jordisala1991

@phansys phansys

Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@VincentLanglet @jordisala1991 @phansys