Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce visibility from getEntityManager #1547

Merged
merged 2 commits into from
Oct 31, 2021
Merged

Reduce visibility from getEntityManager #1547

merged 2 commits into from
Oct 31, 2021
+18 −5

Conversation

VincentLanglet
Copy link
Member

@VincentLanglet VincentLanglet commented Oct 14, 2021 •
edited
Loading

Subject

Changelog

### Deprecated
- Calling `ModelManager::getEntityManager()`

core23
core23 reviewed Oct 14, 2021
View reviewed changes
src/Model/ModelManager.php
@@ -167,6 +167,8 @@ public function findOneBy(string $class, array $criteria = []): ?object
}

/**
* NEXT_MAJOR: Change the visibility to private.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could use @internal to mark this as private?

@VincentLanglet
Reduce visibility from getEntityManager

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
0e811da
@VincentLanglet VincentLanglet force-pushed the entityManager branch 3 times, most recently from 264283c to d7b5330 Compare October 28, 2021 18:15
@jordisala1991
Copy link
Member

This needs to be merged first to fix the build right?

@VincentLanglet
Fix phpstan tests

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
7befdda
@VincentLanglet VincentLanglet marked this pull request as ready for review October 30, 2021 19:03
@VincentLanglet VincentLanglet requested review from a team, core23 and jordisala1991 October 30, 2021 19:03
@VincentLanglet VincentLanglet mentioned this pull request Oct 30, 2021
Merged
@VincentLanglet VincentLanglet requested a review from a team October 31, 2021 07:49
@VincentLanglet VincentLanglet merged commit afc8456 into sonata-project:4.x Oct 31, 2021
@VincentLanglet VincentLanglet deleted the entityManager branch October 31, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordisala1991 jordisala1991

@core23 core23

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@VincentLanglet @jordisala1991 @core23