Small correction in README #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umarcor
approved these changes
Jan 3, 2020
|
@nickolashkraus, thanks! That allowed to rebase many other PRs that failed because of the year. |
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Jan 4, 2020
|
@umarcor Anything else required from me on this PR? |
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Jan 6, 2020
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Jan 22, 2020
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Jan 22, 2020
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Feb 3, 2020
Closed
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Feb 20, 2020
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Mar 1, 2020
|
|
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Apr 13, 2020
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
May 11, 2020
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
May 11, 2020
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
May 11, 2020
|
This PR is being marked as stale due to a long period of inactivity |
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Jul 4, 2020
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Jul 11, 2020
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Jul 13, 2020
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Aug 29, 2020
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Sep 25, 2020
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Oct 1, 2020
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Oct 14, 2020
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Oct 18, 2020
Closed
jpmcb
requested changes
Jun 30, 2021
There was a problem hiding this comment.
Hi @nickolashkraus - thank you so much for the contribution!!
Looks like there is a conflict in the readme. Can you update and I'll get this in ASAP?
Closed
|
Hi @nickolashkraus - any chance we can get an update from you on this? Otherwise, I'll close this and open an issue to address this - thanks much |
|
@jpmcb Sorry I missed your original message! Rebased and addressed merge conflicts |
umarcor
approved these changes
Nov 2, 2021
umarcor
pushed a commit
to umarcor/cobra
that referenced
this pull request
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought this sentence seemed off:
In the Viper documentation:
One would assume that:
Testing with
cobra initbears this out:cobra init --pkg-name testcobra init --pkg-name test --author Me