Remove/replace SetOutput on Command - deprecated#1078
Merged
jharshman merged 4 commits intospf13:masterfrom Apr 6, 2020
Merged
Remove/replace SetOutput on Command - deprecated#1078jharshman merged 4 commits intospf13:masterfrom
jharshman merged 4 commits intospf13:masterfrom
Conversation
|
|
Collaborator
@jpmcb yeah let's not remove it entirely. This is an exported method and we have no way of knowing the extent to which it is used in other projects. |
jharshman
requested changes
Apr 3, 2020
This reverts commit 6291af1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1071
This removes the
SetOutputmethod on*Commandas it is deprecated and replaces those methods withSetOutandSetErr.I didn't touch any of the
SetOutputmethods on*FlagSetas that appears to be apart of thegithub.com/spf13/pflaglibrary. Do we think it's valuable to change that library as well?If we don't want to entirely remove the function just yet, let me know!