Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to specify a filePostpender in GenMarkdownTreeCustom #1270

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Add the ability to specify a filePostpender in GenMarkdownTreeCustom #1270

merged 1 commit into from
Jan 21, 2021

Conversation

sonjoonho
Copy link
Contributor

Closes #1140.

@CLAassistant
Copy link

CLAassistant commented Nov 2, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jharshman jharshman requested a review from jpmcb December 18, 2020 23:17
jpmcb
jpmcb approved these changes Jan 21, 2021
View reviewed changes
Copy link
Collaborator

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! 🚀 and apologies for the long review - been a busy last few months! Cheers

Everything looks good and thanks so much for adding tests!!

@jpmcb jpmcb merged commit 23a6174 into spf13:master Jan 21, 2021
@marckhouzam
Copy link
Collaborator

marckhouzam commented Jan 23, 2021 •
edited
Loading

@jpmcb Helm's compilation is failing with this change.
With this PR, the public function GenMarkdownTreeCustom() now requires an extra argument.
Maybe we need a new funciton instead?

jpmcb added a commit that referenced this pull request Jan 23, 2021
@jpmcb
Revert "Add the ability to specify a filePostpender in GenMarkdownTre…
3c1a0ab 
…eCustom (#1270)"

This reverts commit 23a6174.
@jpmcb jpmcb mentioned this pull request Jan 23, 2021
Merged
@jpmcb
Copy link
Collaborator

jpmcb commented Jan 23, 2021

Thanks for the heads up @marckhouzam - created #1317 to revert and we can revisit this. My apologies - should have caught that!

jpmcb added a commit that referenced this pull request Jan 23, 2021
@jpmcb
Revert "Add the ability to specify a filePostpender in GenMarkdownTre…
ff416ad 
…eCustom (#1270)" (#1317)

This reverts commit 23a6174.
@jpmcb jpmcb mentioned this pull request Jan 25, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmcb jpmcb jpmcb approved these changes

Assignees

@jpmcb jpmcb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GenMarkdownTreeCustom doesn't have a way to append a footer
4 participants
@sonjoonho @CLAassistant @marckhouzam @jpmcb