Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop mitchellh/go-homedir (#853) #1337

Merged
merged 1 commit into from
Jun 30, 2021
Merged

drop mitchellh/go-homedir (#853) #1337

merged 1 commit into from
Jun 30, 2021

Conversation

umarcor
Copy link
Contributor

@umarcor umarcor commented Feb 4, 2021

Since golang <1.14 were deprecated, mitchellh/go-homedir is not required anymore. The built-in os.UserHomeDir can be used instead.

@umarcor umarcor force-pushed the homedir branch 2 times, most recently from 751c769 to e0f41be Compare February 9, 2021 15:59
@umarcor umarcor mentioned this pull request Feb 11, 2021
Closed
@jpmcb jpmcb self-requested a review February 15, 2021 18:09
@jpmcb jpmcb added area/lib Methods and functions that exist in the cobra library and consumed by users kind/feature A feature request for cobra; new or enhanced behavior labels Feb 15, 2021
@jpmcb jpmcb added this to the 2.0.0 milestone Feb 15, 2021
@github-actions github-actions bot added area/cli [deprecated] For the cobra CLI !!! moved to spf13/cobra-cli and removed area/lib Methods and functions that exist in the cobra library and consumed by users labels Feb 21, 2021
@github-actions
Copy link

This PR is being marked as stale due to a long period of inactivity

@umarcor umarcor mentioned this pull request Jun 29, 2021
Closed
@spf13
Copy link
Owner

spf13 commented Jun 30, 2021

@umarcor can you resolve and merge this which unfortunately has conflicts now that I accepted your usage guide PR?

@umarcor
Copy link
Contributor Author

umarcor commented Jun 30, 2021

@spf13, done. CI is green.

@spf13 spf13 merged commit 8eaca5f into spf13:master Jun 30, 2021
@umarcor umarcor deleted the homedir branch June 30, 2021 19:31
@marckhouzam marckhouzam mentioned this pull request Jul 5, 2021
Closed
@marckhouzam marckhouzam removed this from the 2.0.0 milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spf13 spf13 spf13 approved these changes

@jpmcb jpmcb Awaiting requested review from jpmcb

Assignees
No one assigned
Labels
area/cli [deprecated] For the cobra CLI !!! moved to spf13/cobra-cli kind/feature A feature request for cobra; new or enhanced behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@umarcor @spf13 @marckhouzam @jpmcb