Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍁 Fall 2021 - release candidate #1525

Closed
wants to merge 8 commits into from
Closed

Conversation

umarcor
Copy link
Contributor

@umarcor umarcor commented Nov 5, 2021

I rebased the PRs listed in #1496 into a branch.

/cc @marckhouzam @jpmcb

@github-actions github-actions bot added area/cli [deprecated] For the cobra CLI !!! moved to spf13/cobra-cli area/docs-generation Generation of docs via Cobra admin For general admin tasks to be done usualy by maintainers labels Nov 5, 2021
@marckhouzam
Copy link
Collaborator

This is very useful. I am worried of not having enough soak time for all these PRs interacting together, so this branch will allow running different test suites to help make sure we have a stable release.

Thanks @umarcor

@jpmcb
Copy link
Collaborator

jpmcb commented Nov 15, 2021

Amazing!!! Love this idea - we should totally have a release candidate PR for each release. Thanks much for this - will also use for some testing

@jpmcb jpmcb mentioned this pull request Nov 15, 2021
@umarcor
Copy link
Contributor Author

umarcor commented Nov 15, 2021

@jpmcb regardless of the merging order in this PR, go ahead and pick the changes at your own will. I'll keep rebasing and reorganising this PR if necessary.

@jpmcb
Copy link
Collaborator

jpmcb commented Nov 15, 2021

Sweet! Slow going on my end, apologies, but we will make it through this release hopefully soon! 💪🏼

@marckhouzam
Copy link
Collaborator

I've run the completion automated tests (https://github.com/marckhouzam/cobra-completion-testing) on this release candidate as well as helm's go tests and helm's acceptance completion tests (https://github.com/helm/acceptance-testing) and everything passes. It is not guarantee but it is a good sign.

However, I've expressed concerns directly in #1495 (which has now been removed from the release candidate) and #1500.

@umarcor umarcor force-pushed the 2021-fall branch 2 times, most recently from 3019df6 to 0919d04 Compare December 7, 2021 23:05
@github-actions github-actions bot removed the area/cli [deprecated] For the cobra CLI !!! moved to spf13/cobra-cli label Dec 7, 2021
@umarcor umarcor force-pushed the 2021-fall branch 2 times, most recently from 685f3e5 to 5e97685 Compare December 7, 2021 23:25
@umarcor
Copy link
Contributor Author

umarcor commented Dec 10, 2021

Closed because this PR served its purpose already. See #1496.

@marckhouzam
Copy link
Collaborator

This was a really useful initative. Thanks for doing it @umarcor !

@jpmcb
Copy link
Collaborator

jpmcb commented Dec 10, 2021

Agreed - I really want to make this apart of all future release cycles. Was really helpful for trying out builds as we merged things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin For general admin tasks to be done usualy by maintainers area/docs-generation Generation of docs via Cobra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants