-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🍁 Fall 2021 - release candidate #1525
Conversation
This is very useful. I am worried of not having enough soak time for all these PRs interacting together, so this branch will allow running different test suites to help make sure we have a stable release. Thanks @umarcor |
Amazing!!! Love this idea - we should totally have a release candidate PR for each release. Thanks much for this - will also use for some testing |
@jpmcb regardless of the merging order in this PR, go ahead and pick the changes at your own will. I'll keep rebasing and reorganising this PR if necessary. |
Sweet! Slow going on my end, apologies, but we will make it through this release hopefully soon! 💪🏼 |
65d652b
to
2cfc4be
Compare
5e8a9eb
to
d4b42d6
Compare
I've run the completion automated tests (https://github.com/marckhouzam/cobra-completion-testing) on this release candidate as well as helm's go tests and helm's acceptance completion tests (https://github.com/helm/acceptance-testing) and everything passes. It is not guarantee but it is a good sign. However, I've expressed concerns directly in #1495 (which has now been removed from the release candidate) and #1500. |
3019df6
to
0919d04
Compare
685f3e5
to
5e97685
Compare
Closed because this PR served its purpose already. See #1496. |
This was a really useful initative. Thanks for doing it @umarcor ! |
Agreed - I really want to make this apart of all future release cycles. Was really helpful for trying out builds as we merged things. |
I rebased the PRs listed in #1496 into a branch.
/cc @marckhouzam @jpmcb