Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🍒 Cherry-pick v1.6.x - Check for group presence after full initialization (#1839) #1841

Merged
merged 1 commit into from
Oct 24, 2022
Merged

🍒 Cherry-pick v1.6.x - Check for group presence after full initialization (#1839) #1841

merged 1 commit into from
Oct 24, 2022

Conversation

jpmcb
Copy link
Collaborator

@jpmcb jpmcb commented Oct 24, 2022 

Fixes #1831

By moving the check for help group existence to "ExecuteC()" we no longer need groups to be added before AddCommand() is called.  This provides more flexibility to developers and works better with the use of "init()" for command creation.

Signed-off-by: Marc Khouzam <[email protected]>

@marckhouzam @jpmcb
Check for group presence after full initialization (spf13#1839)
fc059a3 
Fixes spf13#1831

By moving the check for help group existence to "ExecuteC()" we no
longer need groups to be added before AddCommand() is called.  This
provides more flexibility to developers and works better with the use
of "init()" for command creation.

Signed-off-by: Marc Khouzam <[email protected]>
@jpmcb jpmcb changed the title 🍒 Cherry-pick - Check for group presence after full initialization (#1839) 🍒 Cherry-pick v1.6.x - Check for group presence after full initialization (#1839) Oct 24, 2022
marckhouzam
marckhouzam approved these changes Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @jpmcb 🚀

@marckhouzam marckhouzam added the lgtm Denotes "looks good to me" from maintainers and signals other collaboratores that a PR is ready label Oct 24, 2022
@jpmcb jpmcb merged commit b43be99 into spf13:v1.6.x Oct 24, 2022
@jpmcb jpmcb deleted the v1.6.x branch October 24, 2022 16:59
@marckhouzam marckhouzam added this to the 1.6.1 milestone Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marckhouzam marckhouzam marckhouzam approved these changes

Assignees
No one assigned
Labels
lgtm Denotes "looks good to me" from maintainers and signals other collaboratores that a PR is ready
Projects
None yet
Milestone
1.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jpmcb @marckhouzam