Added unit tests for RBAC package#490
Merged
maia-iyer merged 6 commits intospiffe:devfrom Sep 16, 2024
Merged
Conversation
added 3 commits
September 3, 2024 18:22
Signed-off-by: Xuhang Cao <ccao@oberlin.edu>
Signed-off-by: Xuhang Cao <ccao@oberlin.edu>
Signed-off-by: Xuhang Cao <ccao@oberlin.edu>
maia-iyer
requested changes
Sep 6, 2024
Collaborator
maia-iyer
left a comment
There was a problem hiding this comment.
Thank you for these tests! my only comment is that the errors may change slightly within the next couple versions, so let's make the error checks slightly more general
Signed-off-by: Xuhang Cao <ccao@oberlin.edu>
maia-iyer
requested changes
Sep 9, 2024
Collaborator
maia-iyer
left a comment
There was a problem hiding this comment.
Almost there! It looks like you need to import the "strings" library. Be sure to test with go test!
added 2 commits
September 13, 2024 15:38
Signed-off-by: Xuhang Cao <ccao@oberlin.edu>
Signed-off-by: Xuhang Cao <ccao@oberlin.edu>
maia-iyer
pushed a commit
that referenced
this pull request
Sep 17, 2024
* Start writing rbac tests Signed-off-by: Xuhang Cao <ccao@oberlin.edu> * Start writing rbac tests Signed-off-by: Xuhang Cao <ccao@oberlin.edu> * Start writing rbac tests Signed-off-by: Xuhang Cao <ccao@oberlin.edu> * Changed error messages Signed-off-by: Xuhang Cao <ccao@oberlin.edu> * Imported strings Signed-off-by: Xuhang Cao <ccao@oberlin.edu> * Imported strings Signed-off-by: Xuhang Cao <ccao@oberlin.edu> --------- Signed-off-by: Xuhang Cao <ccao@oberlin.edu>
maia-iyer
pushed a commit
that referenced
this pull request
Sep 17, 2024
* Start writing rbac tests Signed-off-by: Xuhang Cao <ccao@oberlin.edu> * Start writing rbac tests Signed-off-by: Xuhang Cao <ccao@oberlin.edu> * Start writing rbac tests Signed-off-by: Xuhang Cao <ccao@oberlin.edu> * Changed error messages Signed-off-by: Xuhang Cao <ccao@oberlin.edu> * Imported strings Signed-off-by: Xuhang Cao <ccao@oberlin.edu> * Imported strings Signed-off-by: Xuhang Cao <ccao@oberlin.edu> --------- Signed-off-by: Xuhang Cao <65797697+Xiaocao-Cxh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added rbac tests as discussed on Tuesday meeting Sep 3.