Skip to content

Comments

fix: make sure chainIds are strings and unique#363

Merged
ChaituVR merged 1 commit intomasterfrom
fix-chainids-string
Apr 1, 2025
Merged

fix: make sure chainIds are strings and unique#363
ChaituVR merged 1 commit intomasterfrom
fix-chainids-string

Conversation

@ChaituVR
Copy link
Member

@ChaituVR ChaituVR commented Apr 1, 2025

Right now UI send chainIds as Int, we need to convert it into string

How to test:

Send request with:

curl --location 'http://localhost:3008' \
--header 'Content-Type: application/json' \
--data '{
    "method": "lookup_domains",
    "params": "0x24F15402C6Bb870554489b2fd2049A85d75B982f",
    "network": 1
}'

@ChaituVR ChaituVR requested review from bonustrack and wa0x6e April 1, 2025 16:39
wa0x6e
wa0x6e previously approved these changes Apr 1, 2025
Copy link
Contributor

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

Copy link
Contributor

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@ChaituVR ChaituVR merged commit 575200e into master Apr 1, 2025
0 of 4 checks passed
@ChaituVR ChaituVR deleted the fix-chainids-string branch April 1, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants