Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation issue under linux #700

Closed
cedricboudinet opened this issue Mar 29, 2018 · 6 comments · Fixed by #701
Closed

Installation issue under linux #700

cedricboudinet opened this issue Mar 29, 2018 · 6 comments · Fixed by #701

Comments

@cedricboudinet
Copy link
Contributor

cedricboudinet commented Mar 29, 2018

Hello,
stlink installation under Linux (Debian 9) is broken since modifications for #695: libstlink.so (and others) installs in /usr/local/lib/lib instead of /usr/local/lib
It seems that the error comes from these instructions:
if(IS_DIRECTORY CMAKE_LIBRARY_PATH)
else()
set(CMAKE_LIBRARY_PATH "lib")
endif()
If I change it to
if(IS_DIRECTORY CMAKE_LIBRARY_PATH)
else()
set(CMAKE_LIBRARY_PATH "")
endif()
then it works again.
I can create a PR if you want, but I cannot test the modification under other OS.

@cedricboudinet cedricboudinet changed the title Installation issue under linu Installation issue under linux Mar 29, 2018
@Vascom
Copy link
Collaborator

Vascom commented Mar 29, 2018

I can confirm.
Also hardcode path to "lib" breake x86_64 with /usr/lib64 folder.

@xor-gate
Copy link
Member

Hi guys, I agree with your both. We must find a working solution for all cases (with less cmake code).

@xor-gate xor-gate added this to the Unplanned (Contributions Welcome) milestone Mar 29, 2018
@Vascom
Copy link
Collaborator

Vascom commented Mar 29, 2018

May be if defined LIB_INSTALL_DIR then blank CMAKE_LIBRARY_PATH?
Or blank it for linux always.

@slyshykO
Copy link
Collaborator

slyshykO commented Mar 29, 2018

In my defence, I will say that I encounter a situation when CMAKE_LIBRARY_PATH is a list of paths. That broke all install command completely.
In my opinion, we should remove CMAKE_LIBRARY_PATH from all install commands.

slyshykO added a commit to slyshykO/stlink that referenced this issue Mar 30, 2018
Use CMAKE_INSTALL_PREFIX for install paths
@Cheng-SG
Copy link

I encountered the same issue

@Vascom
Copy link
Collaborator

Vascom commented Mar 30, 2018

@Cheng-SG please try #701 fix

joede pushed a commit to joede/stlink that referenced this issue Apr 17, 2018
@Nightwalker-87 Nightwalker-87 modified the milestones: Unplanned (Contributions Welcome), Next Feb 19, 2020
@Nightwalker-87 Nightwalker-87 modified the milestones: General, v1.5.1 Feb 21, 2020
@Nightwalker-87 Nightwalker-87 linked a pull request Mar 18, 2020 that will close this issue
@Nightwalker-87 Nightwalker-87 linked a pull request Mar 18, 2020 that will close this issue
@stlink-org stlink-org locked as resolved and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants