Moved glmmTMB require statement in plot_type_ranef to come after the model class check #858
+11
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
plot_model()
withtype = "re"
(and by extensionplot_type_ranef()
) on anlme4
model object currently throws an error ifglmmTMB
is not installed:Package 'glmmTMB' required for this function to work, please install it.
However, looking at the
plot_type_ranef()
code it doesn't seem likeglmmTMB
is actually necessary to plotlme4
ranefs. There is a require call forglmmTMB
at the top ofplot_type_ranef()
, before the control flow actually checks whether the model is anlme4
orglmmTMB
model.I've moved the
glmmTMB
require statement so that the model class is checked first. IfglmmTMB
is not actually necessary, not having it installed won't throw an error.I considered moving the
lme4
require statement as well, butsjstats
(and by extensionsjPlot
) has it as a hard dependency anyway, so it should always be installed ifplot_type_ranef()
is called.