Skip to content
This repository was archived by the owner on Feb 4, 2023. It is now read-only.

feat: Update heading component #225

Merged
merged 8 commits into from
Sep 26, 2022
Merged

feat: Update heading component #225

merged 8 commits into from
Sep 26, 2022
+290 −243

Conversation

re-taro
Copy link
Member

@re-taro re-taro commented Sep 23, 2022

📝 what

  • headingコンポーネントをリファクタリングした

✅ check

  • このリポジトリのルールに則っているか
  • テストを書いた or もう書いてある or 書く必要のない修正
  • 動作検証をした

ℹ️ issue

ref #190

@re-taro re-taro added this to the v1.0.0 -> v2.0.0 milestone Sep 23, 2022
@re-taro re-taro requested a review from Sansai-snct September 23, 2022 18:10
@re-taro re-taro self-assigned this Sep 23, 2022
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 23, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: dc990a3
Status: ✅  Deploy successful!
Preview URL: https://140f21d6.2022-hp.pages.dev
Branch Preview URL: https://feat--190.2022-hp.pages.dev

View logs

@github-actions
Copy link

❌ failed...

Open the report at https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1663956836214-63536.report.html

auditProperty actual expected level
performance 0.79 0.9 ❌ error

@github-actions
Copy link

❌ failed...

Open the report at https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1663957676413-25634.report.html

auditProperty actual expected level
performance 0.79 0.9 ❌ error

@github-actions
Copy link

❌ failed...

Open the report at https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1663972642314-84639.report.html

auditProperty actual expected level
performance 0.79 0.9 ❌ error

@re-taro
chore: Fix caching in app.tsx

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
ec019ce
@re-taro
chore: Update Storybook background color

Verified

This commit was signed with the committer’s verified signature. The key has expired.
re-taro Rintaro Itokawa
GPG key ID: 2AA3C0F31FE4280A
Expired
Verified
Learn about vigilant mode
df1e990
@re-taro
chore: Update ESLint rule

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
4977f51
@re-taro
feat: Update heading component
7df94a1 
Become more colorful but it is WIP
@re-taro
chore: Update snapshot
9b006dc
@re-taro
fix: Fix CI
4938d7d 
fix model to optional type
@github-actions
Copy link

❌ failed...

Open the report at https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1663995526865-74746.report.html

auditProperty actual expected level
performance 0.79 0.9 ❌ error

@github-actions
Copy link

❌ failed...

Open the report at https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1664205258643-44586.report.html

auditProperty actual expected level
performance 0.79 0.9 ❌ error

@re-taro re-taro marked this pull request as ready for review September 26, 2022 15:31
@re-taro re-taro merged commit e2561f0 into dev Sep 26, 2022
@re-taro re-taro deleted the feat/#190 branch September 26, 2022 17:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Sansai-snct Sansai-snct

Assignees

@re-taro re-taro

Labels
None yet
Projects
None yet
Milestone
v1.0.0 -> v2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@re-taro @Sansai-snct