Skip to content
This repository was archived by the owner on Feb 4, 2023. It is now read-only.

PRテンプレートを作成した #39

Merged
merged 2 commits into from
Jul 4, 2022
Merged

PRテンプレートを作成した #39

merged 2 commits into from
Jul 4, 2022

Conversation

re-taro
Copy link
Member

@re-taro re-taro commented Jul 4, 2022

📝 what

  • PRテンプレートを作成した

😎 why

  • コードレビューをしやすくするため

✅ check

  • このリポジトリのルールに則っているか
  • テストを書いた or もう書いてある or 書く必要のない修正
  • 動作検証をした

ℹ️ issue

close: #32

Siteproxy
re-taro added 2 commits July 4, 2022 21:50

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@github-actions
Copy link

github-actions bot commented Jul 4, 2022

❌ failed...

Open the report at https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1656939634514-32981.report.html

auditProperty actual expected level
seo 0.82 0.9 ❌ error

Copy link
Contributor

@kobapi28 kobapi28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@re-taro re-taro merged commit 1cf0a39 into dev Jul 4, 2022
@re-taro re-taro deleted the feature/#32 branch July 4, 2022 15:38
re-taro added a commit that referenced this pull request Jul 4, 2022
Merge pull request #39 from suzuka-kosen-festa/feature/#32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants