Skip to content
This repository was archived by the owner on Feb 4, 2023. It is now read-only.

テスト用のライブラリをvitestに変更しました #41

Merged
merged 9 commits into from
Jul 5, 2022

Conversation

re-taro
Copy link
Member

@re-taro re-taro commented Jul 4, 2022

📝 what

  • テスト用のライブラリをvitestに変更しました。

😎 why

  • Jestは設定が肥大化する
  • Storybookと連携で使っていたテスト用のライブラリがReact18未対応だからせっかくだしvitestを使おうと思った
  • 設定もそこまで苦じゃない。強いて言うならvite-plugin-babel-macrosがないと動かないのが現状で、これのメンテナンスがされなくなったらまた別案を考えようと思う

✅ check

  • このリポジトリのルールに則っているか
  • テストを書いた or もう書いてある or 書く必要のない修正
  • 動作検証をした

ℹ️ issue

close: #40

re-taro added 7 commits July 5, 2022 00:29

Verified

This commit was signed with the committer’s verified signature.
re-taro Rintaro Itokawa
we use now vitest
Rintaro use WebStorm
Merge pull request #39 from suzuka-kosen-festa/feature/#32
@re-taro re-taro marked this pull request as ready for review July 4, 2022 15:42
@github-actions
Copy link

github-actions bot commented Jul 4, 2022

❌ failed...

Open the report at https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1656949546763-79936.report.html

auditProperty actual expected level
seo 0.82 0.9 ❌ error

@github-actions
Copy link

github-actions bot commented Jul 4, 2022

❌ failed...

Open the report at https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1656949564845-95329.report.html

auditProperty actual expected level
seo 0.82 0.9 ❌ error

Copy link
Contributor

@kobapi28 kobapi28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn test:uiのコマンドを実行するときに、@vitest/uiのインストールを求められた。
それ以外はきちんと動作することを確認しました!

@vitest/uiを導入して、yarn test:uiを叩くときちんと動作することも確認

@github-actions
Copy link

github-actions bot commented Jul 4, 2022

❌ failed...

Open the report at https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1656976901298-97052.report.html

auditProperty actual expected level
seo 0.82 0.9 ❌ error

Copy link
Contributor

@kobapi28 kobapi28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あぷろーぶです

Copy link
Member

@Bayathy Bayathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あぷろぶおけ

Copy link
Collaborator

@Sansai-snct Sansai-snct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@re-taro re-taro merged commit edcee41 into dev Jul 5, 2022
@re-taro re-taro deleted the feature/#40 branch July 5, 2022 08:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants