Skip to content
This repository was archived by the owner on Feb 4, 2023. It is now read-only.

prettier.ymlの変更が取り込まれていないものを修正 #47

Merged
merged 6 commits into from
Jul 8, 2022

Conversation

re-taro
Copy link
Member

@re-taro re-taro commented Jul 7, 2022

📝 what

  • prettier.ymlの変更が取り込まれていないものを修正

😎 why

  • 修正前は整形するだけしてそれを反映していなかった

✅ check

  • このリポジトリのルールに則っているか
  • テストを書いた or もう書いてある or 書く必要のない修正
  • 動作検証をした

ℹ️ issue

close: #46

Siteproxy
re-taro added 2 commits July 7, 2022 21:04

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

❌ failed...

Open the report at https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1657196754133-89057.report.html

auditProperty actual expected level
seo 0.82 0.9 ❌ error

@github-actions
Copy link

github-actions bot commented Jul 7, 2022

❌ failed...

Open the report at https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1657196861087-73204.report.html

auditProperty actual expected level
seo 0.82 0.9 ❌ error

@github-actions
Copy link

github-actions bot commented Jul 7, 2022

❌ failed...

Open the report at https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1657197145348-41592.report.html

auditProperty actual expected level
seo 0.82 0.9 ❌ error

@re-taro re-taro linked an issue Jul 7, 2022 that may be closed by this pull request
Sansai-snct
Sansai-snct previously approved these changes Jul 7, 2022
Copy link
Collaborator

@Sansai-snct Sansai-snct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

re-taro added 2 commits July 7, 2022 22:34
# Conflicts:
#	src/components/atoms/text/text.test.tsx
#	src/tests/pages/index.test.tsx
#	vitest.config.ts
#	vitest.setup.ts
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

❌ failed...

Open the report at https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1657201163329-138.report.html

auditProperty actual expected level
seo 0.82 0.9 ❌ error

Copy link
Collaborator

@Sansai-snct Sansai-snct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

@re-taro re-taro merged commit 54308e5 into dev Jul 8, 2022
@re-taro re-taro deleted the feature/#46 branch July 8, 2022 00:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

format時に変更を反映する
2 participants