Skip to content
This repository was archived by the owner on Feb 4, 2023. It is now read-only.

Atomic Designに沿った実装かをチェックするマッチャーの適用 #86

Merged
merged 7 commits into from
Jul 20, 2022

Conversation

re-taro
Copy link
Member

@re-taro re-taro commented Jul 19, 2022

📝 what

  • Atomic Designに沿った実装かをチェックするマッチャーの適用

😎 why

  • Atomic Designに沿った実装ができているかをコードレビューでいちいち確認するのは煩わしく感じたため。

✅ check

  • このリポジトリのルールに則っているか
  • テストを書いた or もう書いてある or 書く必要のない修正
  • 動作検証をした

ℹ️ issue

close #66

Siteproxy
re-taro and others added 6 commits July 17, 2022 00:29

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Merge pull request #76 from suzuka-kosen-festa/main

Verified

This commit was signed with the committer’s verified signature. The key has expired.
re-taro Rintaro Itokawa
Merge branch 'feature/#56' into dev

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
詳しい動作はコードを確認してください

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Merge pull request #84 from suzuka-kosen-festa/feature/#83
@re-taro re-taro marked this pull request as ready for review July 19, 2022 13:46
@re-taro re-taro linked an issue Jul 19, 2022 that may be closed by this pull request
@github-actions
Copy link

❌ failed...

Open the report at https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1658238626212-48252.report.html

auditProperty actual expected level
seo 0.82 0.9 ❌ error

@github-actions
Copy link

❌ failed...

Open the report at https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1658241010983-2418.report.html

auditProperty actual expected level
seo 0.82 0.9 ❌ error

@re-taro re-taro merged commit 486fc3b into dev Jul 20, 2022
@re-taro re-taro deleted the feature/#66 branch July 20, 2022 22:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Atomic Design を導入されているかのテストを書く
2 participants