Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install-time and runtime warnings (e.g. "not for production use") for polyfill #1447

Closed
justingrant opened this issue Mar 11, 2021 · 2 comments
Assignees

Comments

@justingrant
Copy link
Collaborator

The current Temporal polyfill doesn't display any warnings at install time that it's not intended for production use. I'm not sure if it shows console warnings at runtime, but I don't think it does.

Now that we're in Stage 3, users may assume that the polyfill is intended for production use, which it's not.

So how about we add both an install-time warning and a console warning to give users a heads up?

@ljharb
Copy link
Member

ljharb commented Mar 12, 2021

an install-time warning can be achieved most easily by using npm deprecate.

@justingrant
Copy link
Collaborator Author

This warning was completed in #1622. Thanks all for your patience. See #1446 (comment) for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants