Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add release build target "linux-aarch64-musl" for platform "linux/arm64" #351

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

nifr
Copy link
Contributor

@nifr nifr commented Jan 16, 2024

First of all THANK YOU for all the work you put into tealdeer and this awesome open-source project in general ❤️

This PR adds support for the linux/arm64 platform (which is required for i.e. Linux Docker images on Apple M1/M2/M3 Chips). 🚀

I'd love to download the linux/arm64 binary directly from releases in this repository in the future.
If possible please create a new release after merge.

I have tested the build process and binary release with a fictional v1.6.2 release in my fork.

You can find the release here: github.com/nifr/tealdeer/releases/tag/v1.6.2

Try it as follows:

# start a arm64 docker image
docker run --rm -it --platform=linux/arm64 debian:bullseye-slim

# download the binary
curl -sL \
 -o /usr/local/bin/tldr \
  https://github.com/nifr/tealdeer/releases/download/v1.6.2/tealdeer-linux-aarch64-musl
  
 # make it executable
chmod +x /usr/local/bin/tldr

# try "tldr" commands
tldr --update
tldr --version
LANGUAGE=en tldr git
LANGUAGE=de tldr git

# install "file" to inspect the binary
apt-get update
apt-get install -yq file

# show ELF information for the binary
file /usr/local/bin/tldr

Screenshot of my binary test on a MacBook Air 2023 (M2):

Screenshot 2024-01-17 at 00 41 43

Copy link
Collaborator

@dbrgn dbrgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice words and detailed PR description!

@dbrgn dbrgn merged commit d04e671 into tealdeer-rs:main Jan 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants