Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] sof_ri_info.py fails on Intel MTL+ binaries #8073

Closed
kv2019i opened this issue Aug 22, 2023 · 5 comments · Fixed by thesofproject/rimage#173
Closed

[BUG] sof_ri_info.py fails on Intel MTL+ binaries #8073

kv2019i opened this issue Aug 22, 2023 · 5 comments · Fixed by thesofproject/rimage#173
Assignees
Labels
bug Something isn't working as expected LNL Applies to Lunar Lake platform MTL Applies to Meteor Lake platform P1 Blocker bugs or important features
Milestone

Comments

@kv2019i
Copy link
Collaborator

kv2019i commented Aug 22, 2023

Describe the bug
Following error is seen when using the script on recent MTL binaries:

$ ./sof_ri_info.py sof-mtl.ri
Traceback (most recent call last):
File "./sof_ri_info.py", line 1717, in
main(ARGS)
File "./sof_ri_info.py", line 1694, in main
fw_bin = parse_fw_bin(args.sof_ri_path, args.no_cse, args.verbose)
File "./sof_ri_info.py", line 906, in parse_fw_bin
parsed_bin.add_comp(parse_cse_manifest(reader))
File "./sof_ri_info.py", line 681, in parse_cse_manifest
entry_file_offset + entry_length)
File "./sof_ri_info.py", line 704, in parse_css_manifest
return parse_css_manifest_4(css_mft, reader, limit)
File "./sof_ri_info.py", line 769, in parse_css_manifest_4
assert reader.get_offset() == size_limit # wrong extension length
AssertionError

To Reproduce

Reproduction Rate

Expected behavior

Impact

Environment

  1. Branch name and commit hash of the 2 repositories: sof (firmware/topology) and linux (kernel driver).
    • Kernel: {SHA}
    • SOF: {SHA}
  2. Name of the topology file
    • Topology: n/a
  3. Name of the platform(s) on which the bug is observed.
    • Platform: MTL
@kv2019i kv2019i added bug Something isn't working as expected MTL Applies to Meteor Lake platform labels Aug 22, 2023
@lgirdwood lgirdwood added this to the v2.7 milestone Aug 22, 2023
@alex-cri alex-cri added the P1 Blocker bugs or important features label Aug 22, 2023
@marc-hb marc-hb changed the title [BUG] sof_ri_info.oy fails on Intel MTL+ binaries [BUG] sof_ri_info.py fails on Intel MTL+ binaries Aug 24, 2023
@marc-hb
Copy link
Collaborator

marc-hb commented Aug 24, 2023

Known issue: 842c39f

@kv2019i kv2019i self-assigned this Aug 24, 2023
@kv2019i kv2019i added the LNL Applies to Lunar Lake platform label Aug 24, 2023
kv2019i added a commit to kv2019i/rimage that referenced this issue Aug 24, 2023
The ADSP.man contents is different for ACE_V1_5 layout
compared to CAVS_V2_5 layout. so the ADSP.man length should
be adjusted accordingly.

With this fix, sof_ri_info.py can be used to analyze
LNL and MTL firmware images created with rimage.

Closes: thesofproject/sof#8073
Signed-off-by: Kai Vehmanen <[email protected]>
@kv2019i
Copy link
Collaborator Author

kv2019i commented Aug 24, 2023

Issue rootcaused, fix in thesofproject/rimage#173

@kv2019i
Copy link
Collaborator Author

kv2019i commented Aug 25, 2023

Reopening until rimage update is done to SOF main with this fix.

EDIT: rimage upgraded in SOF by

@marc-hb
Copy link
Collaborator

marc-hb commented Aug 28, 2023

@marc-hb
Copy link
Collaborator

marc-hb commented Aug 28, 2023

Thanks @kv2019i ! Enabling sof_ri_info.py on MTL and LNL at last in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected LNL Applies to Lunar Lake platform MTL Applies to Meteor Lake platform P1 Blocker bugs or important features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants