Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Alpine and Golang #102

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Conversation

PascalBourdier
Copy link
Contributor

use Go 1.17 and Alpine 3.15

use Go 1.17 and Alpine 3.15
@tianon
Copy link
Owner

tianon commented Mar 8, 2022

I agree with making these updates, but similar to #101 (comment) (see also #98), I want to make sure I'm not merging this with a false expectation -- I do not plan to make a new release with these updates unless there's a more compelling reason to do so than "my security scanner says it's vulnerable" (because the scan result itself is an overzealous scanner -- ultimately the vulnerability is a false positive).

@tianon
Copy link
Owner

tianon commented Mar 8, 2022

Would you also be willing to update hub/Dockerfile.alpine? 🙏

(I'm happy to take over from here if you'd prefer!)

Comment on lines +5 to 7
require github.com/opencontainers/runc v1.1.0

require (
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This split is interesting -- is this something the go tooling did automatically?

Copy link
Contributor Author

@PascalBourdier PascalBourdier Mar 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the number of explicit requirements may be substantially larger in an expanded Go 1.17 go.mod file, the newly-added requirements on indirect dependencies in a go 1.17 module are maintained in a separate require block from the block containing direct dependencies.

it seems native in Golang 1.17 : https://go.dev/doc/go1.17#tools

@slakwa slakwa mentioned this pull request Mar 9, 2022
@PascalBourdier
Copy link
Contributor Author

Would you also be willing to update hub/Dockerfile.alpine? 🙏

(I'm happy to take over from here if you'd prefer!)

I fixed it

@tianon tianon merged commit b185278 into tianon:master Mar 9, 2022
@tianon
Copy link
Owner

tianon commented Mar 9, 2022

Thanks!

@slakwa
Copy link

slakwa commented Mar 16, 2022

@tianon I have a question about this change. Shouldn't also the version of gosu be updated from 1.14 to 1.15 for other tools using this library to be able to get this change?

@tianon
Copy link
Owner

tianon commented Mar 16, 2022

See #104 -- I do not plan to rebuild/release a new version of gosu for vulnerability reports that do not actually apply to the released binaries (or the corresponding source code).

This PR was merged because it's generally a good idea to keep up-to-date, and I want to make sure that if/when there is a new release of gosu, it's built on the latest appropriate versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants