Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shasum: add page #1514

Merged
merged 4 commits into from
Oct 6, 2017
Merged

shasum: add page #1514

merged 4 commits into from
Oct 6, 2017

Conversation

alpreu
Copy link

@alpreu alpreu commented Oct 4, 2017


  • The page (if new), does not already exist in the repo.

  • The page (if new), has been added to the correct platform folder:
    common/ if it's common to all platforms, linux/ if it's Linux-specific, and so on.

  • The page has 8 or fewer examples.

  • The PR is appropriately titled:
    <command name>: add page for new pages, or <command name>: <description of changes> for pages being edited

  • The page follows the contributing guidelines

@agnivade
Copy link
Member

agnivade commented Oct 4, 2017

Is this available on Windows too ? If not, then you should create separate entries in linux and osx folder. And remove this from common.

@alpreu
Copy link
Author

alpreu commented Oct 4, 2017

@agnivade Oh sorry, I didn't quite understand that common included windows. I will create a new commit.

@agnivade
Copy link
Member

agnivade commented Oct 4, 2017

It's mentioned in the PR template which you tick marked -

The page (if new), has been added to the correct platform folder:  
      `common/` if it's common to all platforms, `linux/` if it's Linux-specific, and so on.

Let me know if there is something that can be improved.

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the page! I've made a few comments on the linux version of the page, but they apply to both 😺


- Calculate the SHA256 checksum for a file:

`shasum -a 256 {{filename}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you could use the long form of the argument name here? So instead of -a use --algorithm?


- Check a file with a list of sums against the directorys files:

`shasum -c {{list_file}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.


`shasum -a 512 {{filename1}} {{filename2}}`

- Check a file with a list of sums against the directorys files:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: directorys -> directory's

@alpreu
Copy link
Author

alpreu commented Oct 5, 2017

@sbrl I incorporated your comments :)
@agnivade I thought Common meant shared between osx and other *nixes. Maybe 'Crossplatform' might be a better term, or an explicit note that this includes Windows?

@agnivade agnivade added the new command Issues requesting creation of a new page. label Oct 5, 2017
@sbrl sbrl merged commit c063dbf into tldr-pages:master Oct 6, 2017
@sbrl
Copy link
Member

sbrl commented Oct 6, 2017

@alpreu Thanks for the page 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants