-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shasum: add page #1514
shasum: add page #1514
Conversation
Is this available on Windows too ? If not, then you should create separate entries in linux and osx folder. And remove this from common. |
@agnivade Oh sorry, I didn't quite understand that common included windows. I will create a new commit. |
It's mentioned in the PR template which you tick marked -
Let me know if there is something that can be improved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the page! I've made a few comments on the linux version of the page, but they apply to both 😺
pages/linux/shasum.md
Outdated
|
||
- Calculate the SHA256 checksum for a file: | ||
|
||
`shasum -a 256 {{filename}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps you could use the long form of the argument name here? So instead of -a
use --algorithm
?
pages/linux/shasum.md
Outdated
|
||
- Check a file with a list of sums against the directorys files: | ||
|
||
`shasum -c {{list_file}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
pages/linux/shasum.md
Outdated
|
||
`shasum -a 512 {{filename1}} {{filename2}}` | ||
|
||
- Check a file with a list of sums against the directorys files: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: directorys
-> directory's
@alpreu Thanks for the page 😺 |
The page (if new), does not already exist in the repo.
The page (if new), has been added to the correct platform folder:
common/
if it's common to all platforms,linux/
if it's Linux-specific, and so on.The page has 8 or fewer examples.
The PR is appropriately titled:
<command name>: add page
for new pages, or<command name>: <description of changes>
for pages being editedThe page follows the contributing guidelines