popd: add page #1517

juan88 · 2017-10-05T02:38:45Z

The page (if new), does not already exist in the repo.
The page (if new), has been added to the correct platform folder:
common/ if it's common to all platforms, linux/ if it's Linux-specific, and so on.
The page has 8 or fewer examples.
The PR is appropriately titled:
<command name>: add page for new pages, or <command name>: <description of changes> for pages being edited
The page follows the contributing guidelines

tldr-bot · 2017-10-05T02:39:24Z

The build for this PR has failed with the following error(s):

pages/common/popd.md:9: TLDR104 Example descriptions should prefer infinitive tense (e.g. write) over present (e.g. writes) or gerund (e.g. writing)
pages/common/popd.md:13: TLDR104 Example descriptions should prefer infinitive tense (e.g. write) over present (e.g. writes) or gerund (e.g. writing)
pages/common/popd.md:16: TLDR008 File should contain no trailing whitespace

Please fix the error(s) and push again.

tldr-bot · 2017-10-05T02:43:44Z

The build for this PR has failed with the following error(s):

pages/common/popd.md:9: TLDR104 Example descriptions should prefer infinitive tense (e.g. write) over present (e.g. writes) or gerund (e.g. writing)
pages/common/popd.md:13: TLDR104 Example descriptions should prefer infinitive tense (e.g. write) over present (e.g. writes) or gerund (e.g. writing)

Please fix the error(s) and push again.

agnivade · 2017-10-05T05:40:13Z

@katekyan / @juan88 - Please remove the commit for the timeout page and do a force push again. Thanks.

juan88 · 2017-10-05T11:07:28Z

Sure no problem. Can you point me in the right direction on how to do it? It's my second pull request ever so please excuse me if I've made a mistake while adding my changes. I also found out that I made an error with the commit message I typed the wrong command. If you prefer you can dismiss that pull request and I'll do it again. 2017-10-05 2:40 GMT-03:00 Agniva De Sarker <[email protected]>:

…

@katekyan <https://github.com/katekyan> / @juan88 <https://github.com/juan88> - Please remove the commit for the timeout page and do a force push again. Thanks. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1517 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AG1xiRyi-ON_xUngcJNQLLFBZ7Ga5kJrks5spGvCgaJpZM4PufVj> .

agnivade · 2017-10-05T15:24:29Z

So, ideally a single branch should contain commits pertaining to only that PR. In your case, you have the popd branch. This branch has now 4 commits. And we need to get rid of the last commit and push again. The following is what I would do, but there are different ways of achieving this.

In your current branch, do git reset --hard HEAD^. This deletes the last commit. And then do a git push -f origin popd. That should update the remote branch with the new changes. That's it.

For further assistance, @waldyrious might be able to help you out.

juan88 · 2017-10-05T16:20:37Z

That might have happened when I synced the branch with master since another push had been done right? I'll try to fix it today and thank you for your assistance. 2017-10-05 12:24 GMT-03:00 Agniva De Sarker <[email protected]>:

…

So, ideally a single branch should contain commits pertaining to only that PR. In your case, you have the popd branch. This branch has now 4 commits. And we need to get rid of the last commit and push again. The following is what I would do, but there are different ways of achieving this. In your current branch, do git reset --hard HEAD^. This deletes the last commit. And then do a git push -f origin popd. That should update the remote branch with the new changes. That's it. For further assistance, @waldyrious <https://github.com/waldyrious> might be able to help you out. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1517 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AG1xiU_BYDjXz4Lb12fKwBybJSPiMSj_ks5spPS2gaJpZM4PufVj> .

sbrl

I think this PR is titled wrong! This looks like a good page for popd, not pushd lol :P

Updating PR title.

sbrl · 2017-10-06T12:24:18Z

pages/common/popd.md

@@ -0,0 +1,15 @@
+# Popd


Popd should be all lowercase here.

sbrl · 2017-10-06T12:25:14Z

pages/common/popd.md

+
+`popd`
+
+- Remove the Nth directory (starting from zero to the left from the list printed with dirs):


Perhaps enclosing dirs in backticks would aid clarity here?

sbrl · 2017-10-06T12:25:28Z

pages/common/popd.md

+
+`popd +N`
+
+- Remove the Nth directory (starting from zero to the right from the list printed with dirs):


Fixed as requested.

juan88 · 2017-10-06T12:32:37Z

Yeah I made a mistake with the title. Been trying to mimic pushd page got me confused, sorry! I'll add those backticks and the uppercase fix today. Thanks for the clarifications! 2017-10-06 9:26 GMT-03:00 Starbeamrainbowlabs <[email protected]>:

…

***@***.**** requested changes on this pull request. I think this PR is titled wrong! This looks like a good page for popd, not pushd lol :P Updating PR title. ------------------------------ In pages/common/popd.md <#1517 (comment)>: > @@ -0,0 +1,15 @@ +# Popd Popd should be all lowercase here. ------------------------------ In pages/common/popd.md <#1517 (comment)>: > @@ -0,0 +1,15 @@ +# Popd + +> Remove a directory placed on the directory stack via the pushd shell built-in. + +- Remove the top directory from the stack and cd to it: + +`popd` + +- Remove the Nth directory (starting from zero to the left from the list printed with dirs): Perhaps enclosing dirs in backticks would aid clarity here? ------------------------------ In pages/common/popd.md <#1517 (comment)>: > @@ -0,0 +1,15 @@ +# Popd + +> Remove a directory placed on the directory stack via the pushd shell built-in. + +- Remove the top directory from the stack and cd to it: + +`popd` + +- Remove the Nth directory (starting from zero to the left from the list printed with dirs): + +`popd +N` + +- Remove the Nth directory (starting from zero to the right from the list printed with dirs): Same here. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1517 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AG1xicOhKm5ZZYkCMPmGuL1eC58WFjAPks5sphxugaJpZM4PufVj> .

agnivade · 2017-10-06T15:25:48Z

@juan88 - Please check for the command in osx and windows platforms. If not, duplicate the page into their respective folders.

juan88 · 2017-10-06T21:01:09Z

@agnivade Moved the page to osx and linux since in windows the command takes less parameters and the examples are more appropiate for osx/linux.

The same happens with pushd. In windows, parameters for the command are different. Should be still placed under common? Want me to open a new issue with this?

https://technet.microsoft.com/en-us/library/bb490969.aspx
https://technet.microsoft.com/en-us/library/bb490978.aspx

agnivade · 2017-10-07T05:09:54Z

Very interesting. In this case, the page should have 3 different copies across the 3 folders. Please add another page under windows, with the windows specific parameters. Thanks for looking into this.

juan88 · 2017-10-08T01:13:01Z

@agnivade

Please add another page under windows, with the windows specific parameters

Do you mean common folder or should I create a new folder pages/windows for this issue? Thanks!

agnivade · 2017-10-08T09:24:54Z

Oh my bad .. I didn't realise that we don't have a windows folder at all. Yes, please create the new folder and add the page there.

tldr-bot · 2017-10-09T02:22:50Z

The build for this PR has failed with the following error(s):

pages/windows/popd.md:3: TLDR004 Command descriptions should end in a period
pages/windows/popd.md:1: TLDR009 Page should contain a newline at end of file

Please fix the error(s) and push again.

agnivade · 2017-10-09T10:05:49Z

pages/linux/popd.md

@@ -0,0 +1,15 @@
+# popd
+
+> Remove a directory placed on the directory stack via the pushd shell built-in.


"via the pushd shell built-in" => "by the pushd command"
To make it consistent with the windows page. And also command sounds better than shell built-in. 😆

agnivade · 2017-10-09T10:06:43Z

@juan88 - Thanks for being patient with the review process. We are nearly there. Just one small thing to take care of.

sbrl · 2017-10-09T20:11:47Z

The new windows folder begins! If I end up using a windows machine in the near future and I remember, I'll look at sending a PR for a few windows-specific commands :P

juan88 · 2017-10-10T02:18:47Z

Sure! No problem! Always glad to help and learn! 👍

sbrl · 2017-10-11T10:25:44Z

Thanks, @juan88! Thanks for sticking with it throughout the review process 😺

juan88 · 2017-10-11T21:04:09Z

No problem! Thanks for your patience! It's nice to be able to contribute to open source projects.

pushd: add page

a5fc0b5

pushd: fix trailing whitespace

08c725e

pushd: fix example description

7f63bce

agnivade added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Oct 5, 2017

juan88 force-pushed the popd branch from 968476f to 7f63bce Compare October 5, 2017 17:54

sbrl requested changes Oct 6, 2017

View reviewed changes

sbrl changed the title ~~pushd: add page~~ popd: add page Oct 6, 2017

juan88 added 2 commits October 6, 2017 17:51

popd: fixed description. Added in linux and osx. Removed from common.

04ba47c

popd: Modified description

5f255cc

popd: added page for windows

f103ad0

popd: fix format issues

c773e52

juan88 mentioned this pull request Oct 9, 2017

pushd: added platform specific examples in windows, osx and linux. Removed from common. #1535

Merged

5 tasks

agnivade requested changes Oct 9, 2017

View reviewed changes

popd: fixed description

57d3300

agnivade approved these changes Oct 10, 2017

View reviewed changes

sbrl approved these changes Oct 11, 2017

View reviewed changes

sbrl merged commit 4024334 into tldr-pages:master Oct 11, 2017

sbrl mentioned this pull request Oct 25, 2017

page request: popd #1510

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

popd: add page #1517

popd: add page #1517

juan88 commented Oct 5, 2017

tldr-bot commented Oct 5, 2017

tldr-bot commented Oct 5, 2017

agnivade commented Oct 5, 2017

juan88 commented Oct 5, 2017 via email

agnivade commented Oct 5, 2017

juan88 commented Oct 5, 2017 via email

sbrl left a comment

sbrl Oct 6, 2017

sbrl Oct 6, 2017

sbrl Oct 6, 2017

juan88 Oct 6, 2017

juan88 commented Oct 6, 2017 via email

agnivade commented Oct 6, 2017

juan88 commented Oct 6, 2017

agnivade commented Oct 7, 2017

juan88 commented Oct 8, 2017

agnivade commented Oct 8, 2017

tldr-bot commented Oct 9, 2017

agnivade Oct 9, 2017

agnivade commented Oct 9, 2017

sbrl commented Oct 9, 2017

juan88 commented Oct 10, 2017

sbrl commented Oct 11, 2017

juan88 commented Oct 11, 2017


		`popd`

		- Remove the Nth directory (starting from zero to the left from the list printed with dirs):


		`popd +N`

		- Remove the Nth directory (starting from zero to the right from the list printed with dirs):

		@@ -0,0 +1,15 @@
		# popd

		> Remove a directory placed on the directory stack via the pushd shell built-in.

popd: add page #1517

popd: add page #1517

Conversation

juan88 commented Oct 5, 2017

tldr-bot commented Oct 5, 2017

tldr-bot commented Oct 5, 2017

agnivade commented Oct 5, 2017

juan88 commented Oct 5, 2017 via email

agnivade commented Oct 5, 2017

juan88 commented Oct 5, 2017 via email

sbrl left a comment

Choose a reason for hiding this comment

sbrl Oct 6, 2017

Choose a reason for hiding this comment

sbrl Oct 6, 2017

Choose a reason for hiding this comment

sbrl Oct 6, 2017

Choose a reason for hiding this comment

juan88 Oct 6, 2017

Choose a reason for hiding this comment

juan88 commented Oct 6, 2017 via email

agnivade commented Oct 6, 2017

juan88 commented Oct 6, 2017

agnivade commented Oct 7, 2017

juan88 commented Oct 8, 2017

agnivade commented Oct 8, 2017

tldr-bot commented Oct 9, 2017

agnivade Oct 9, 2017

Choose a reason for hiding this comment

agnivade commented Oct 9, 2017

sbrl commented Oct 9, 2017

juan88 commented Oct 10, 2017

sbrl commented Oct 11, 2017

juan88 commented Oct 11, 2017