stat: add page #1518
Merged
stat: add page #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this should go to the linux folder, not common. |
|
I'm not a mac user but from searching in google it says it is available.
I might check it later at work from a macs friend if needed.
2017-10-05 0:58 GMT-03:00 Agniva De Sarker <[email protected]>:
… I believe this should go to the linux folder, not common.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1518 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AG1xiUNIxqkKoMdRE475D9CbBEizbjSMks5spFPSgaJpZM4Pug29>
.
|
|
Common includes mac, windows and linux. I was talking about windows. I'm afraid you have to do the same thing you did with popd. |
|
Thanks for your feedback. I'll make the necessary changes to make it right!
2017-10-05 12:25 GMT-03:00 Agniva De Sarker <[email protected]>:
… Common includes mac, windows and linux. I was talking about windows. I'm
afraid you have to do the same thing you did with popd.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1518 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AG1xibY2QWg0pFerRVELVdHvqHeWfe5Qks5spPUDgaJpZM4Pug29>
.
|
|
|
Yes, it seems to exist - http://www.unix.com/man-page/FreeBSD/1/stat/. Do you plan to add the page later ? |
|
Could not test it on a mac yet. I try today at work if my collegue comes to
the office and I'll add it.
2017-10-09 9:09 GMT-03:00 Agniva De Sarker <[email protected]>:
… I'm not a mac user but from searching in google it says it is available.
Yes, it seems to exist - http://www.unix.com/man-page/FreeBSD/1/stat/. Do
you plan to add the page later ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1518 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AG1xiQqu8rUtc33gLup8W1-UNfkb-3Vfks5sqgzfgaJpZM4Pug29>
.
|
- Fix minor grammar mistake - Removed the octal file permissions as they have been already mentioned above.
- Fix a minor grammar error - Removed the file permissions example and only kept the file owner and group.
|
Thanks for your work @juan88 . I made some simplifications of my own. Please have a look and let me know if everything looks good. |
Looks great! thank you for your patience and guidance throughout the process. |
agnivade
approved these changes
Oct 16, 2017
|
Looks good to me! Thanks, @juan88 😺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1487
The page (if new), does not already exist in the repo.
The page (if new), has been added to the correct platform folder:
common/if it's common to all platforms,linux/if it's Linux-specific, and so on.The page has 8 or fewer examples.
The PR is appropriately titled:
<command name>: add pagefor new pages, or<command name>: <description of changes>for pages being editedThe page follows the contributing guidelines