ufw: Added an example of rule comments #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnivade
reviewed
Oct 6, 2017
pages/linux/ufw.md
Outdated
| @@ -15,9 +15,9 @@ | |||
|
|
|||
| `ufw status numbered` | |||
|
|
|||
| - Allow incoming traffic on port 5432 on this host: | |||
| - Allow incoming traffic on port 5432 on this host and an identifing comment: | |||
There was a problem hiding this comment.
typo => identifing
And I recommend using "with an" instead of "and an" to signify that this comment is paired with that rule.
agnivade
approved these changes
Oct 6, 2017
|
Looks good to me 😺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the more obscure features of UFW is being able to add comments to your rules and was only added last year. This feature helps significantly when managing a complicated rule set.
I tried to shim it in to an existing example without introducing too much complexity as the entry already has eight examples.
The page (if new), does not already exist in the repo.The page (if new), has been added to the correct platform folder:
common/if it's common to all platforms,linux/if it's Linux-specific, and so on.The page has 8 or fewer examples.
The PR is appropriately titled:
<command name>: add pagefor new pages, or<command name>: <description of changes>for pages being editedThe page follows the contributing guidelines