-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r: add page #1524
r: add page #1524
Conversation
The build for this PR has failed with the following error(s):
Please fix the error(s) and push again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok! Just a minor point or two 😺
pages/common/r.md
Outdated
@@ -0,0 +1,15 @@ | |||
# R |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It really is a single letter command that's uppercase? That's rather unusual.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup! Though I've seen many versions where it calls for the lower case, though that may just be aliased.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would really hate to break convention here. All our pages have the heading as lowercase. Unless there is a different command with a lower case r
, I would recommend changing this to lowercase.
pages/common/r.md
Outdated
|
||
> R language interpreter. | ||
|
||
- Call a R interactive shell (REPL): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer an
instead of a
in this instance, as R
is a single character.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me!
pages/common/r.md
Outdated
@@ -0,0 +1,15 @@ | |||
# R |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would really hate to break convention here. All our pages have the heading as lowercase. Unless there is a different command with a lower case r
, I would recommend changing this to lowercase.
pages/common/r.md
Outdated
|
||
`R --version` | ||
|
||
- Run file as input: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this to - "Execute a file" to keep it consistent with pages of other programming languages.
pages/common/r.md
Outdated
|
||
- Run file as input: | ||
|
||
`R -f file.R` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrap file.R in tokens
pages/common/r.md
Outdated
|
||
> R language interpreter. | ||
|
||
- Call an R interactive shell (REPL): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Call => Start
The page (if new), does not already exist in the repo.
The page (if new), has been added to the correct platform folder:
common/
if it's common to all platforms,linux/
if it's Linux-specific, and so on.The page has 8 or fewer examples.
The PR is appropriately titled:
<command name>: add page
for new pages, or<command name>: <description of changes>
for pages being editedThe page follows the contributing guidelines