-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mongod: add page #1525
mongod: add page #1525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the page, I have left some comments.
pages/common/mongod.md
Outdated
@@ -0,0 +1,15 @@ | |||
# mongod | |||
|
|||
> The daemon process for MongoDB. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest changing this line to "The MongoDB database server"
pages/common/mongod.md
Outdated
|
||
> The daemon process for MongoDB. | ||
|
||
- Specify runtime configurations: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
runtime configurations => a config file
pages/common/mongod.md
Outdated
|
||
- Specify runtime configurations: | ||
|
||
`mongod --config <filename>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<filename> => {{filename}}
pages/common/mongod.md
Outdated
|
||
`mongod --config <filename>` | ||
|
||
- Specify port for MongoDB to listen to client connections: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specify the port to listen on.
pages/common/mongod.md
Outdated
|
||
- Specify port for MongoDB to listen to client connections: | ||
|
||
`mongod --port <port>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<port> => {{port}}
pages/common/mongod.md
Outdated
|
||
`mongod --port <port>` | ||
|
||
- Change database profiling level. 0 is off, 1 is only slow operations, 2 is all: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change => Specify. And wrap the last sentence in parenthesis.
pages/common/mongod.md
Outdated
|
||
- Change database profiling level. 0 is off, 1 is only slow operations, 2 is all: | ||
|
||
`mongod --profile <level>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
=> {{0|1|2}}
The build for this PR has failed with the following error(s):
Please fix the error(s) and push again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me! Looks like you've created all sorts of pages recently, @YangVincent - thanks 😺
If you're interested in sticking around, perhaps we could grant you member privileges? Can't remember what the procedure is there. @waldyrious / @agnivade?
Sure, I'd love that! I use tldr pretty often so it's nice to be able to contribute to the project |
I think we should let @YangVincent hang around for a little more time to get a feel for the overall theme for this project, before granting him higher privileges. |
Good idea, @agnivade |
Fixes #1176
The page (if new), does not already exist in the repo.
The page (if new), has been added to the correct platform folder:
common/
if it's common to all platforms,linux/
if it's Linux-specific, and so on.The page has 8 or fewer examples.
The PR is appropriately titled:
<command name>: add page
for new pages, or<command name>: <description of changes>
for pages being editedThe page follows the contributing guidelines