Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mongod: add page #1525

Merged
merged 3 commits into from
Oct 7, 2017
Merged

mongod: add page #1525

merged 3 commits into from
Oct 7, 2017

Conversation

YangVincent
Copy link

@YangVincent YangVincent commented Oct 6, 2017

Fixes #1176


  • The page (if new), does not already exist in the repo.

  • The page (if new), has been added to the correct platform folder:
    common/ if it's common to all platforms, linux/ if it's Linux-specific, and so on.

  • The page has 8 or fewer examples.

  • The PR is appropriately titled:
    <command name>: add page for new pages, or <command name>: <description of changes> for pages being edited

  • The page follows the contributing guidelines

@YangVincent
Copy link
Author

YangVincent commented Oct 6, 2017

#1176

@agnivade agnivade added the new command Issues requesting creation of a new page. label Oct 7, 2017
Copy link
Member

@agnivade agnivade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the page, I have left some comments.

@@ -0,0 +1,15 @@
# mongod

> The daemon process for MongoDB.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest changing this line to "The MongoDB database server"


> The daemon process for MongoDB.

- Specify runtime configurations:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runtime configurations => a config file


- Specify runtime configurations:

`mongod --config <filename>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<filename> => {{filename}}


`mongod --config <filename>`

- Specify port for MongoDB to listen to client connections:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specify the port to listen on.


- Specify port for MongoDB to listen to client connections:

`mongod --port <port>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<port> => {{port}}


`mongod --port <port>`

- Change database profiling level. 0 is off, 1 is only slow operations, 2 is all:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change => Specify. And wrap the last sentence in parenthesis.


- Change database profiling level. 0 is off, 1 is only slow operations, 2 is all:

`mongod --profile <level>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=> {{0|1|2}}

@tldr-bot
Copy link

tldr-bot commented Oct 7, 2017

The build for this PR has failed with the following error(s):

pages/common/mongod.md:3: TLDR004 Command descriptions should end in a period

Please fix the error(s) and push again.

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me! Looks like you've created all sorts of pages recently, @YangVincent - thanks 😺

If you're interested in sticking around, perhaps we could grant you member privileges? Can't remember what the procedure is there. @waldyrious / @agnivade?

@sbrl sbrl merged commit eae235b into tldr-pages:master Oct 7, 2017
@YangVincent
Copy link
Author

Sure, I'd love that! I use tldr pretty often so it's nice to be able to contribute to the project

@YangVincent YangVincent deleted the mongod branch October 8, 2017 03:34
@agnivade
Copy link
Member

agnivade commented Oct 8, 2017

I think we should let @YangVincent hang around for a little more time to get a feel for the overall theme for this project, before granting him higher privileges.

@sbrl
Copy link
Member

sbrl commented Oct 9, 2017

Good idea, @agnivade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants