Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locust: add page #1534

Merged
merged 1 commit into from
Oct 11, 2017
Merged

locust: add page #1534

merged 1 commit into from
Oct 11, 2017

Conversation

pit1s
Copy link

@pit1s pit1s commented Oct 8, 2017


  • The page (if new), does not already exist in the repo.

  • The page (if new), has been added to the correct platform folder:
    common/ if it's common to all platforms, linux/ if it's Linux-specific, and so on.

  • The page has 8 or fewer examples.

  • The PR is appropriately titled:
    <command name>: add page for new pages, or <command name>: <description of changes> for pages being edited

  • The page follows the contributing guidelines

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2017

CLA assistant check
All committers have signed the CLA.


> Load-testing tool to determine number of concurrent users a system can handle.

- Load-test example.com with web interface using locustfile.py:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put example.com in quotes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@agnivade agnivade added the new command Issues requesting creation of a new page. label Oct 8, 2017

- Connect locust slave to master on a different machine:

`locust --slave --master-host={{master_ip}} --host={{http://example.com}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change it to "master_hostname" because the option mentions "master-host" ?

Copy link
Author

@pit1s pit1s Oct 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only used IP for my tests but you can do both. I'll change it to avoid confusion. Thanks for the feedback.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@sbrl sbrl merged commit ae695bd into tldr-pages:master Oct 11, 2017
@sbrl
Copy link
Member

sbrl commented Oct 11, 2017

Looks ok to me! Thanks @pit1s 😺

@pit1s
Copy link
Author

pit1s commented Oct 11, 2017

@sbrl Happy to help 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants