-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ldconfig: add page #1536
ldconfig: add page #1536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got a few comments 😺
pages/linux/ldconfig.md
Outdated
|
||
> Configure symlinks and cache for shared library dependencies. | ||
|
||
- Update symlinks and rebuild the cache. (Usually run when a new library is installed): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think the full stop is needed here. Also, I'm not sure that Usually
needs a capital letter at the beginning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
pages/linux/ldconfig.md
Outdated
|
||
`sudo ldconfig` | ||
|
||
- Update symlinks for a given directory: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps Update symlinks
-> Update the symlinks
reads better?
pages/linux/ldconfig.md
Outdated
|
||
`sudo ldconfig -n {{path/to/directory}}` | ||
|
||
- Print the libraries in the cache and check whether a given library is present: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps just including the ldconfig -p
bit would be ok? Not sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You would almost always never use ldconfig -p
without wanting to check for a particular library. This is how the -p flag is commonly used and in the interest of putting useful and practical examples, I have added the grep line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh ok. Looks good to me then!
- Added "the" in the 2nd example - Removed full stop and made the next word to be lowercase in the first example
The page (if new), does not already exist in the repo.
The page (if new), has been added to the correct platform folder:
common/
if it's common to all platforms,linux/
if it's Linux-specific, and so on.The page has 8 or fewer examples.
The PR is appropriately titled:
<command name>: add page
for new pages, or<command name>: <description of changes>
for pages being editedThe page follows the contributing guidelines