Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fd: add page #1563

Merged
merged 3 commits into from
Oct 24, 2017
Merged

fd: add page #1563

merged 3 commits into from
Oct 24, 2017

Conversation

einnjo
Copy link
Contributor

@einnjo einnjo commented Oct 21, 2017


  • The page (if new), does not already exist in the repo.

  • The page (if new), has been added to the correct platform folder:
    common/ if it's common to all platforms, linux/ if it's Linux-specific, and so on.

  • The page has 8 or fewer examples.

  • The PR is appropriately titled:
    <command name>: add page for new pages, or <command name>: <description of changes> for pages being edited

  • The page follows the contributing guidelines

@agnivade
Copy link
Member

Does this command exist in windows too ?

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, except for a small point I've commented about below.

@agnivade: I believe it is available for windows, yes. It seems to be from here: https://github.com/sharkdp/fd


> A simple, fast and user-friendly alternative to find.

- Find files under current dir that match a pattern:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, but it might be a good idea to expand dir to directory. What do you think, @agnivade / @waldyrious?

@agnivade agnivade added the new command Issues requesting creation of a new page. label Oct 22, 2017
@sbrl sbrl merged commit fc91506 into tldr-pages:master Oct 24, 2017
@sbrl
Copy link
Member

sbrl commented Oct 24, 2017

Thanks, @juanjoLenero! 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants