-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
borg: add page #1631
borg: add page #1631
Conversation
The build for this PR has failed with the following error(s):
Please fix the error(s) and push again. |
@ckovsky - Please sign the CLA. We can get on with the review after that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pages/common/borg.md
Outdated
# borg | ||
|
||
> Deduplicating backup tool with compression and encryption. | ||
> Supports local and remote backups, mountable as filesystems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that the remote backups have to be mounted as a file system, or that backs can be mounted as a file system?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the backups that can be mountable. But borg can backup remotely over ssh. The command for an init would look like:
$ borg init user@hostname:backup
I wasn't sure whether to include a remote example or not. Wanted to keep it simple :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the description could be simplified. It sounds a bit like an ad...
pages/common/borg.md
Outdated
|
||
- Backup a folder into the repository, creating an archive called Monday: | ||
|
||
`borg create --progress {{/path/to/repo/folder::Monday}} {{/path/to/source/folder}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the ::
required here? Perhaps we could tweak this to {{/path/to/repo/folder}}::{{Monday}}
if that's the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the :: are part of the syntax. I like the suggestion of separating the archive name.
pages/common/borg.md
Outdated
|
||
- Extract a specific folder from the 'Monday' archive, excluding all *.ext files: | ||
|
||
`borg extract {{/path/to/repo/folder::Monday}} {{path/to/target/folder}} --exclude '*.ext'` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps you could put {{
and }}
around *.ext
? Also, is the '
meant to be there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The '
are required, as far as I know. Yes, might be more consistent to add {{
and }}
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. Thanks!
pages/common/borg.md
Outdated
|
||
`borg extract {{/path/to/repo/folder::Monday}} {{path/to/target/folder}} --exclude '*.ext'` | ||
|
||
- Prune a repository, deleting all archives older than 7 days, listing changes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps Prune a repository by deleting
.... would read better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me! Thanks, @ckovsky 😺
pages/common/borg.md
Outdated
# borg | ||
|
||
> Deduplicating backup tool with compression and encryption. | ||
> Supports local and remote backups that are mountable as filesystems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see an example which works on remote backups. Perhaps you can switch one of the examples to work on a remote backup.
pages/common/borg.md
Outdated
|
||
- Initialise a (local) repository: | ||
|
||
`borg init {{/path/to/repo/folder}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change it to path/to/repo_folder
. Apply this convention everywhere.
pages/common/borg.md
Outdated
|
||
`borg init {{/path/to/repo/folder}}` | ||
|
||
- Backup a folder into the repository, creating an archive called Monday: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Monday in quotes ("")
pages/common/borg.md
Outdated
|
||
`borg list {{/path/to/repo/folder}}` | ||
|
||
- Extract a specific folder from the 'Monday' archive, excluding all *.ext files: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Monday in double quotes.
pages/common/borg.md
Outdated
|
||
- Prune a repository by deleting all archives older than 7 days, listing changes: | ||
|
||
`borg prune --keep-within 7d --list {{/path/to/repo/folder}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7d within tokens {}
The page (if new), does not already exist in the repo.
The page (if new), has been added to the correct platform folder:
common/
if it's common to all platforms,linux/
if it's Linux-specific, and so on.The page has 8 or fewer examples.
The PR is appropriately titled:
<command name>: add page
for new pages, or<command name>: <description of changes>
for pages being editedThe page follows the contributing guidelines