Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

borg: add page #1631

Merged
merged 4 commits into from
Nov 18, 2017
Merged

borg: add page #1631

merged 4 commits into from
Nov 18, 2017

Conversation

ckovsky
Copy link
Contributor

@ckovsky ckovsky commented Nov 13, 2017


  • The page (if new), does not already exist in the repo.

  • The page (if new), has been added to the correct platform folder:
    common/ if it's common to all platforms, linux/ if it's Linux-specific, and so on.

  • The page has 8 or fewer examples.

  • The PR is appropriately titled:
    <command name>: add page for new pages, or <command name>: <description of changes> for pages being edited

  • The page follows the contributing guidelines

@CLAassistant
Copy link

CLAassistant commented Nov 13, 2017

CLA assistant check
All committers have signed the CLA.

@tldr-bot
Copy link

The build for this PR has failed with the following error(s):

pages/common/borg.md:6: TLDR003 Descriptions should start with a capital letter
pages/common/borg.md:6: TLDR005 Example descriptions should end in a colon
pages/common/borg.md:10: TLDR003 Descriptions should start with a capital letter
pages/common/borg.md:26: TLDR005 Example descriptions should end in a colon

Please fix the error(s) and push again.

@agnivade
Copy link
Member

@ckovsky - Please sign the CLA. We can get on with the review after that.

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the page, @ckovsky! I've left a few comments suggestions below.

@agnivade It looks like @ckovsky has already signed the CLA?

# borg

> Deduplicating backup tool with compression and encryption.
> Supports local and remote backups, mountable as filesystems.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that the remote backups have to be mounted as a file system, or that backs can be mounted as a file system?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the backups that can be mountable. But borg can backup remotely over ssh. The command for an init would look like:
$ borg init user@hostname:backup

I wasn't sure whether to include a remote example or not. Wanted to keep it simple :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the description could be simplified. It sounds a bit like an ad...


- Backup a folder into the repository, creating an archive called Monday:

`borg create --progress {{/path/to/repo/folder::Monday}} {{/path/to/source/folder}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the :: required here? Perhaps we could tweak this to {{/path/to/repo/folder}}::{{Monday}} if that's the case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the :: are part of the syntax. I like the suggestion of separating the archive name.


- Extract a specific folder from the 'Monday' archive, excluding all *.ext files:

`borg extract {{/path/to/repo/folder::Monday}} {{path/to/target/folder}} --exclude '*.ext'`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you could put {{ and }} around *.ext? Also, is the ' meant to be there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ' are required, as far as I know. Yes, might be more consistent to add {{ and }}.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. Thanks!


`borg extract {{/path/to/repo/folder::Monday}} {{path/to/target/folder}} --exclude '*.ext'`

- Prune a repository, deleting all archives older than 7 days, listing changes:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps Prune a repository by deleting.... would read better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@agnivade agnivade added the new command Issues requesting creation of a new page. label Nov 14, 2017
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me! Thanks, @ckovsky 😺

# borg

> Deduplicating backup tool with compression and encryption.
> Supports local and remote backups that are mountable as filesystems.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see an example which works on remote backups. Perhaps you can switch one of the examples to work on a remote backup.


- Initialise a (local) repository:

`borg init {{/path/to/repo/folder}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change it to path/to/repo_folder. Apply this convention everywhere.


`borg init {{/path/to/repo/folder}}`

- Backup a folder into the repository, creating an archive called Monday:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Monday in quotes ("")


`borg list {{/path/to/repo/folder}}`

- Extract a specific folder from the 'Monday' archive, excluding all *.ext files:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Monday in double quotes.


- Prune a repository by deleting all archives older than 7 days, listing changes:

`borg prune --keep-within 7d --list {{/path/to/repo/folder}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7d within tokens {}

@agnivade agnivade merged commit 1dbea94 into tldr-pages:master Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants