Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbash: add page #1634

Merged
merged 6 commits into from
Nov 20, 2017
Merged

rbash: add page #1634

merged 6 commits into from
Nov 20, 2017

Conversation

zvonimirr
Copy link
Contributor

  • The page (if new), does not already exist in the repo.

  • The page (if new), has been added to the correct platform folder:
    common/ if it's common to all platforms, linux/ if it's Linux-specific, and so on.

  • The page has 8 or fewer examples.

  • The PR is appropriately titled:
    <command name>: add page for new pages, or <command name>: <description of changes> for pages being edited

  • The page follows the contributing guidelines

@tldr-bot
Copy link

The build for this PR has failed with the following error(s):

pages/common/rbash.md:3: TLDR004 Command descriptions should end in a period
pages/common/rbash.md:4: TLDR004 Command descriptions should end in a period
pages/common/rbash.md:5: TLDR003 Descriptions should start with a capital letter
pages/common/rbash.md:5: TLDR004 Command descriptions should end in a period
pages/common/rbash.md:6: TLDR004 Command descriptions should end in a period
pages/common/rbash.md:7: TLDR004 Command descriptions should end in a period
pages/common/rbash.md:8: TLDR004 Command descriptions should end in a period
pages/common/rbash.md:9: TLDR004 Command descriptions should end in a period
pages/common/rbash.md:10: TLDR004 Command descriptions should end in a period
pages/common/rbash.md:11: TLDR004 Command descriptions should end in a period
pages/common/rbash.md:28: TLDR008 File should contain no trailing whitespace

Please fix the error(s) and push again.

# rbash

> Restricted Bash shell.
> Restrictions implemented in rbash.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We allow only 2 lines for heading. Please update it to have only 2 lines.

@zvonimirr
Copy link
Contributor Author

Hello, I changed it can you please take a look now?

@agnivade
Copy link
Member

Made some changes which clarifies the 2nd line a bit.

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me! Just spotted a teensy grammatical error which I fixed.

@sbrl sbrl merged commit 780c9f5 into tldr-pages:master Nov 20, 2017
@agnivade agnivade added the new command Issues requesting creation of a new page. label Nov 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants