-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rbash: add page #1634
rbash: add page #1634
Conversation
The build for this PR has failed with the following error(s):
Please fix the error(s) and push again. |
pages/common/rbash.md
Outdated
# rbash | ||
|
||
> Restricted Bash shell. | ||
> Restrictions implemented in rbash. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We allow only 2 lines for heading. Please update it to have only 2 lines.
Hello, I changed it can you please take a look now? |
Made some changes which clarifies the 2nd line a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me! Just spotted a teensy grammatical error which I fixed.
The page (if new), does not already exist in the repo.
The page (if new), has been added to the correct platform folder:
common/
if it's common to all platforms,linux/
if it's Linux-specific, and so on.The page has 8 or fewer examples.
The PR is appropriately titled:
<command name>: add page
for new pages, or<command name>: <description of changes>
for pages being editedThe page follows the contributing guidelines