Skip to content

Remove ruby 2.x#911

Merged
konalegi merged 2 commits intomasterfrom
remove-ruby-2-x
Dec 13, 2023
Merged

Remove ruby 2.x#911
konalegi merged 2 commits intomasterfrom
remove-ruby-2-x

Conversation

@konalegi
Copy link

@konalegi konalegi commented Dec 12, 2023

Clean-up everything ruby 2. x related, upgrade rubocop, and make it compliant with ruby 3.0 syntax.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the changelog if the new code introduces user-observable changes. See changelog entry format for details.

@konalegi konalegi marked this pull request as ready for review December 12, 2023 16:24
@konalegi konalegi requested a review from a team as a code owner December 12, 2023 16:24
@konalegi konalegi mentioned this pull request Dec 12, 2023
7 tasks
Copy link
Contributor

@alejandroperea alejandroperea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! 👍

Chewy is compatible with MRI 2.6-3.0¹.
Chewy is compatible with MRI 3.0-3.2¹.

> ¹ Ruby 3 is only supported with Rails 6.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it mean? Is it still relevant? Id Ruby 3.0/Rails 7 incompatible?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, it means that ruby 3.0 starts support only with rails 6.1 :)

@konalegi konalegi merged commit f9681e4 into master Dec 13, 2023
@konalegi konalegi deleted the remove-ruby-2-x branch December 13, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants