chore: Bump MSRV to 1.46 #605
Merged
+29
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
733a9be to
5aabe0c
Compare
46a95bd to
68c8047
Compare
olix0r
approved these changes
Oct 18, 2021
|
Many projects do MSRV bumps on minor / patch releases. I don't think this should be considered breaking. 👎 to making |
68c8047 to
718b1c9
Compare
a212239 to
19ccfd0
Compare
davidpdrsn
added a commit
that referenced
this pull request
Oct 19, 2021
davidpdrsn
added a commit
that referenced
this pull request
Oct 19, 2021
* tower: prepare to release 0.4.10 - Fix accidental breaking change when using the `rustdoc::broken_intra_doc_links` lint ([#605]) - Clarity that tower's minimum supported rust version is 1.46 ([#605]) [#605]: #605 * Update tower/CHANGELOG.md Co-authored-by: Oliver Gould <ver@buoyant.io> Co-authored-by: Oliver Gould <ver@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out our CI never ran for 1.40. We were missing
override: true🥲After actually running the tests on 1.40 it turns out we require 1.46 because of tokio and http. Tokio requires 1.45 and http requires 1.46 because of
if/matchinconst fn.httpis only used in tests so we could pin that to 0.2.4 which works on 1.45 but I guess since we might as well go to 1.46.Questions:
util::Eitherto pin-project-lite?I also changed
rustdoc::broken_intra_doc_linksto only be set on CI withRUSTDOCFLAGS.Fixes #604