Fix hardware properties for WebGPU #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max_bindings was reading the wrong thing. That's the number of bind groups, not how many buffers you can have per kernel... On desktop this number was only 8, on WebGPU it's only 4. In reality on desktop it's >>>large, and on Chrome it's currently 10. Should improve fusion a bit on desktop, and a good amount on WebGPU.
Min/max plane size were reported as dummy 0 values, which was causing issues. For now, disable subgroups until wgpu no longer reports dummy values here.