Solution for P12 reading issue in newer OpenSSL #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Adds an alternative method to read P12 files for installations with newer OpenSSL versions, where using the built-in PHP function
openssl_pkcs12_read()fails.This new method relies on invoking
opensslusingshell_exec, which also won't work for everyone, but hopefully increases the number of users for which this will work out of the box.Notes
Also added a basic PHPUnit test, which runs in GitHub Actions on multiple PHP versions, and both with the OpenSSL legacy patch enabled and disabled to ensure future compatibility.
Related issues
Fixes #112